From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B503C432C2 for ; Wed, 25 Sep 2019 17:21:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 732822146E for ; Wed, 25 Sep 2019 17:21:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2442971AbfIYRVv (ORCPT ); Wed, 25 Sep 2019 13:21:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:33026 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2438083AbfIYRVv (ORCPT ); Wed, 25 Sep 2019 13:21:51 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id CDD43AFCF; Wed, 25 Sep 2019 17:21:49 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 3D371DA7D7; Wed, 25 Sep 2019 19:22:10 +0200 (CEST) Date: Wed, 25 Sep 2019 19:22:10 +0200 From: David Sterba To: Johannes Thumshirn Cc: David Sterba , Nikolay Borisov , Linux BTRFS Mailinglist Subject: Re: [PATCH v5 0/7] btrfs-progs: support xxhash64 checksums Message-ID: <20190925172210.GL2751@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Johannes Thumshirn , David Sterba , Nikolay Borisov , Linux BTRFS Mailinglist References: <20190925133728.18027-1-jthumshirn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190925133728.18027-1-jthumshirn@suse.de> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Sep 25, 2019 at 03:37:21PM +0200, Johannes Thumshirn wrote: > Now that Nikolay's XXHASH64 support for the Crypto API has landed and BTRFS is > prepared for an easy addition of new checksums, this patchset implements > XXHASH64 as a second, fast but not cryptographically secure checksum hash. > > This patchset is fully bisectible and available on github at > https://github.com/morbidrsa/btrfs-progs/tree/mkfs-xxhash64.v5 > > Changes since v4: > - Rebased onto latest 'devel' branch and dropped applied changes > - Split 'btrfs-progs: add xxhash64 as checksum algorithm' into several atomic > patches > - Changed test code to using 'TEST_ENABLE_OVERRIDE' > > Johannes Thumshirn (7): > btrfs-progs: add option for checksum type to mkfs > btrfs-progs: add is_valid_csum_type() helper > btrfs-progs: add table for checksum type and name > btrfs-progs: also print checksum type when running mkfs > btrfs-progs: add xxhash64 to mkfs > btrfs-progs: move crc32c implementation to crypto/ All of the above added to devel, thanks. There might be some fixups or cleanups but I'll do them as separate patches. Regarding relese, we could do the xxhash support in 5.3, though there's no kernel support yet. I'll think about that if this would not cause too much confusion though.