From: "Lakshmipathi.G" <lakshmipathi.g@giis.co.in>
To: Philipp Hahn <pmhahn+btrfs@pmhahn.de>
Cc: "Lakshmipathi.G" <lakshmipathi.ganapathi@collabora.com>,
linux-btrfs@vger.kernel.org, dsterba@suse.com,
thecybershadow@gmail.com, wqu@suse.com
Subject: Re: [PATCH] Setup GitLab-CI for btrfs-progs
Date: Mon, 7 Oct 2019 08:55:47 +0530 [thread overview]
Message-ID: <20191007032546.GB5135@giis.co.in> (raw)
In-Reply-To: <1ecbc32d-9f28-b0f5-bf2d-8ceee12d6404@pmhahn.de>
On Tue, Oct 01, 2019 at 08:02:29AM +0200, Philipp Hahn wrote:
>
> You already have a "variables" section above - merge them?
>
> > + services:
> > + - docker:18.09.7-dind
>
> You already have "services" defined globally - no need to repeat that
> here again.
>
Hi Philipp,
Thanks for the comments. I ran into some issue while using global section so
started using job section. Let me try placing them in global and update the
results. thanks.
Cheers.
Lakshmipathi.G
next prev parent reply other threads:[~2019-10-07 3:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 16:56 [PATCH] Setup GitLab-CI for btrfs-progs Lakshmipathi.G
2019-10-01 6:02 ` Philipp Hahn
2019-10-07 3:25 ` Lakshmipathi.G [this message]
2019-10-07 17:52 ` David Sterba
2019-10-14 18:02 ` Lakshmipathi.G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007032546.GB5135@giis.co.in \
--to=lakshmipathi.g@giis.co.in \
--cc=dsterba@suse.com \
--cc=lakshmipathi.ganapathi@collabora.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=pmhahn+btrfs@pmhahn.de \
--cc=thecybershadow@gmail.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).