From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03BD3ECE58C for ; Mon, 7 Oct 2019 17:52:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C570A20684 for ; Mon, 7 Oct 2019 17:52:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728330AbfJGRwX (ORCPT ); Mon, 7 Oct 2019 13:52:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:42526 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728187AbfJGRwW (ORCPT ); Mon, 7 Oct 2019 13:52:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 4958BAF16; Mon, 7 Oct 2019 17:52:21 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 1B626DA7FB; Mon, 7 Oct 2019 19:52:36 +0200 (CEST) Date: Mon, 7 Oct 2019 19:52:35 +0200 From: David Sterba To: "Lakshmipathi.G" Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com, thecybershadow@gmail.com, wqu@suse.com, lakshmipathi.g@giis.co.in Subject: Re: [PATCH] Setup GitLab-CI for btrfs-progs Message-ID: <20191007175235.GL2751@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, "Lakshmipathi.G" , linux-btrfs@vger.kernel.org, dsterba@suse.com, thecybershadow@gmail.com, wqu@suse.com, lakshmipathi.g@giis.co.in References: <20190930165622.GA25114@giis.co.in> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190930165622.GA25114@giis.co.in> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Sep 30, 2019 at 10:26:54PM +0530, Lakshmipathi.G wrote: > Make use of GitLab-CI nested virutal environment to start QEMU instance inside containers > and perform btrfs-progs build, execute unit test cases and save the logs. This looks good, thanks! > More details can be found at https://github.com/kdave/btrfs-progs/issues/171 > > Signed-off-by: Lakshmipathi.G > --- > .gitlab-ci.yml | 181 ++++++++++++++++++++++++++++++++++ > gitlab-ci/Dockerfile | 3 + > gitlab-ci/btrfs-progs-tests.service | 13 +++ > gitlab-ci/build_or_run_btrfs-progs.sh | 37 +++++++ > gitlab-ci/kernel_build.sh | 30 ++++++ > gitlab-ci/run_tests.sh | 9 ++ > gitlab-ci/setup_image.sh | 42 ++++++++ Is it possible to move the files to ci/gitlab? .gitlab-ci.yml must be probably in the top-level dir but that's acceptable. > 7 files changed, 315 insertions(+) > create mode 100644 .gitlab-ci.yml > create mode 100644 gitlab-ci/Dockerfile > create mode 100644 gitlab-ci/btrfs-progs-tests.service > create mode 100755 gitlab-ci/build_or_run_btrfs-progs.sh > create mode 100755 gitlab-ci/kernel_build.sh > create mode 100755 gitlab-ci/run_tests.sh > create mode 100755 gitlab-ci/setup_image.sh The scripts look good to me but I have limited knowledge of the CI environment so I don't have objections against merging the patch. I'll spend some time experimenting but overall this seems in a good shape and we'll get further coverage (due to the new kernel) than what travis provides. Thanks.