Linux-BTRFS Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] btrfs: block-group: Rework documentation of check_system_chunk function
@ 2019-10-08  0:50 Marcos Paulo de Souza
  2019-10-08  7:28 ` Nikolay Borisov
  2019-10-08 11:43 ` David Sterba
  0 siblings, 2 replies; 3+ messages in thread
From: Marcos Paulo de Souza @ 2019-10-08  0:50 UTC (permalink / raw)
  To: dsterba, clm
  Cc: Marcos Paulo de Souza, Josef Bacik, linux-btrfs, linux-kernel

Commit 4617ea3a52cf (" Btrfs: fix necessary chunk tree space calculation
when allocating a chunk") removed the is_allocation argument from
check_system_chunk, since the formula for reserving the necessary space
for allocation or removing a chunk would be the same.

So, rework the comment by removing the mention of is_allocation
argument.

Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
---
 fs/btrfs/block-group.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
index bf7e3f23bba7..4910921838db 100644
--- a/fs/btrfs/block-group.c
+++ b/fs/btrfs/block-group.c
@@ -2987,9 +2987,7 @@ static u64 get_profile_num_devs(struct btrfs_fs_info *fs_info, u64 type)
 }

 /*
- * If @is_allocation is true, reserve space in the system space info necessary
- * for allocating a chunk, otherwise if it's false, reserve space necessary for
- * removing a chunk.
+ * Reserve space in the system space for allocating or removing a chunk
  */
 void check_system_chunk(struct btrfs_trans_handle *trans, u64 type)
 {
--
2.23.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs: block-group: Rework documentation of check_system_chunk function
  2019-10-08  0:50 [PATCH] btrfs: block-group: Rework documentation of check_system_chunk function Marcos Paulo de Souza
@ 2019-10-08  7:28 ` Nikolay Borisov
  2019-10-08 11:43 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: Nikolay Borisov @ 2019-10-08  7:28 UTC (permalink / raw)
  To: Marcos Paulo de Souza, clm, David Sterba
  Cc: Josef Bacik, open list:BTRFS FILE SYSTEM, open list



On 8.10.19 г. 3:50 ч., Marcos Paulo de Souza wrote:
> Commit 4617ea3a52cf (" Btrfs: fix necessary chunk tree space calculation
> when allocating a chunk") removed the is_allocation argument from
> check_system_chunk, since the formula for reserving the necessary space
> for allocation or removing a chunk would be the same.
> 
> So, rework the comment by removing the mention of is_allocation
> argument.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>


> ---
>  fs/btrfs/block-group.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
> index bf7e3f23bba7..4910921838db 100644
> --- a/fs/btrfs/block-group.c
> +++ b/fs/btrfs/block-group.c
> @@ -2987,9 +2987,7 @@ static u64 get_profile_num_devs(struct btrfs_fs_info *fs_info, u64 type)
>  }
> 
>  /*
> - * If @is_allocation is true, reserve space in the system space info necessary
> - * for allocating a chunk, otherwise if it's false, reserve space necessary for
> - * removing a chunk.
> + * Reserve space in the system space for allocating or removing a chunk
>   */
>  void check_system_chunk(struct btrfs_trans_handle *trans, u64 type)
>  {
> --
> 2.23.0
> 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] btrfs: block-group: Rework documentation of check_system_chunk function
  2019-10-08  0:50 [PATCH] btrfs: block-group: Rework documentation of check_system_chunk function Marcos Paulo de Souza
  2019-10-08  7:28 ` Nikolay Borisov
@ 2019-10-08 11:43 ` David Sterba
  1 sibling, 0 replies; 3+ messages in thread
From: David Sterba @ 2019-10-08 11:43 UTC (permalink / raw)
  To: Marcos Paulo de Souza
  Cc: dsterba, clm, Josef Bacik, open list:BTRFS FILE SYSTEM, open list

On Mon, Oct 07, 2019 at 09:50:38PM -0300, Marcos Paulo de Souza wrote:
> Commit 4617ea3a52cf (" Btrfs: fix necessary chunk tree space calculation
> when allocating a chunk") removed the is_allocation argument from
> check_system_chunk, since the formula for reserving the necessary space
> for allocation or removing a chunk would be the same.
> 
> So, rework the comment by removing the mention of is_allocation
> argument.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>

Added to misc-next, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08  0:50 [PATCH] btrfs: block-group: Rework documentation of check_system_chunk function Marcos Paulo de Souza
2019-10-08  7:28 ` Nikolay Borisov
2019-10-08 11:43 ` David Sterba

Linux-BTRFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \
		linux-btrfs@vger.kernel.org linux-btrfs@archiver.kernel.org
	public-inbox-index linux-btrfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs


AGPL code for this site: git clone https://public-inbox.org/ public-inbox