From: Nikolay Borisov <nborisov@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: Nikolay Borisov <nborisov@suse.com>
Subject: [PATCH 0/8] tree reading cleanups in mount
Date: Tue, 15 Oct 2019 18:42:16 +0300 [thread overview]
Message-ID: <20191015154224.21537-1-nborisov@suse.com> (raw)
Hello,
Here is the second version of the tree reading code which gets executed during
mount. This goes a bit further than the previous posting in that it not only
introduces a new function but also refactors the code which decides which backup
root to use. Overall I think the semantics are now much cleaner and centralised
in a single function - init_tree_roots rather than split between mount and
backup root write out.
The series starts gradually by simplifying find_newest_super_backup and its
callers (patches 1-2).
It then paves the way forward by introducing read_backup_rooti (patch 3) which
supersedes (patch 4) next_root_backup, the latter is then removed (patch 6). While
at it I also remove the unnecessary objectid mutex during mount (patch 5).
The final 2 patches streamlines how btrfs_fs_info::backup_root_index is being
initialised.
This patchset has been tested by simulating (via btrfs-corrupt-block) corruption
of the primary root and resorting to using usebackuproot mount option. I've also
added a regression test to btrfs-progs that will follow shortly.
Nikolay Borisov (8):
btrfs: Cleanup and simplify find_newest_super_backup
btrfs: Remove newest_gen argument from find_oldest_super_backup
btrfs: Add read_backup_root
btrfs: Factor out tree roots initialization during mount
btrfs: Don't use objectid_mutex during mount
btrfs: Remove unused next_root_backup function
btrfs: Rename find_oldest_super_backup to init_backup_root_slot
btrfs: Streamline btrfs_fs_info::backup_root_index semantics
fs/btrfs/disk-io.c | 252 ++++++++++++++++++++-------------------------
1 file changed, 113 insertions(+), 139 deletions(-)
--
2.17.1
next reply other threads:[~2019-10-15 15:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 15:42 Nikolay Borisov [this message]
2019-10-15 15:42 ` [PATCH 1/8] btrfs: Cleanup and simplify find_newest_super_backup Nikolay Borisov
2019-10-17 13:56 ` David Sterba
2019-10-15 15:42 ` [PATCH 2/8] btrfs: Remove newest_gen argument from find_oldest_super_backup Nikolay Borisov
2019-10-15 15:42 ` [PATCH 3/8] btrfs: Add read_backup_root Nikolay Borisov
2019-10-15 15:42 ` [PATCH 4/8] btrfs: Factor out tree roots initialization during mount Nikolay Borisov
2019-10-15 15:42 ` [PATCH 5/8] btrfs: Don't use objectid_mutex " Nikolay Borisov
2019-10-15 15:42 ` [PATCH 6/8] btrfs: Remove unused next_root_backup function Nikolay Borisov
2019-10-15 15:42 ` [PATCH 7/8] btrfs: Rename find_oldest_super_backup to init_backup_root_slot Nikolay Borisov
2019-10-15 15:42 ` [PATCH 8/8] btrfs: Streamline btrfs_fs_info::backup_root_index semantics Nikolay Borisov
2019-10-29 16:42 ` [PATCH 0/8] tree reading cleanups in mount David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191015154224.21537-1-nborisov@suse.com \
--to=nborisov@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).