From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1610CA9EA0 for ; Fri, 18 Oct 2019 22:19:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A3C8521852 for ; Fri, 18 Oct 2019 22:19:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="IaOC59DY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393731AbfJRWTs (ORCPT ); Fri, 18 Oct 2019 18:19:48 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39889 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393292AbfJRWTr (ORCPT ); Fri, 18 Oct 2019 18:19:47 -0400 Received: by mail-pf1-f195.google.com with SMTP id v4so4688922pff.6 for ; Fri, 18 Oct 2019 15:19:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=qUpFp9KbBdWTA0E3gLC1f/xv0BL9BCPRfBmIyXLMH9o=; b=IaOC59DYv7KJEbVcYWcyRLrXU1oRgzuR1RM9lexH6K0zqcIc3Z6m34DHWN+ZsJ2wBe LY7mrWxUdAZpPNvKpo8mDvELAYqphBX13rSdoZXNoBmNoA+/ePoP5cofLtUN0o0xmJET Sg2obSCTgbmkdxCSuhDU7T682WIPRAj8hlnrKt3r1pnYeKCbK/GudaH54rAabHouqmiR G6As+0f4zpg4bzcpH63EjDEEtSJzvIQ0Pwi0UArtJJK3EX3NMd6PPAOkVzyh891ib8Yb vjzcDtg4wYqxTAszqHaBdsu1eDPNs8v0MPsL1fHSePiPCRHFxDf5XbrWI+FqYJUpkQ2E X0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=qUpFp9KbBdWTA0E3gLC1f/xv0BL9BCPRfBmIyXLMH9o=; b=gyWuFyiKFWjbmmyNw8pm8++ytSRaMYSM3dzkUy6/bCjiloYQlKeZ58mJBFa4dDAdF+ zUxhTTrX4rn7EXk2m/DPs+qgDAO6ZlP21Y4Yzcphcx1LbCF19ZplT+7KDu7JdlhzmR/4 06JreJOW+L38YUForm3TF66FTVavSxgsS76uGQMYJT/T0rfFTyQwTllJhjp0D5pAmIPh /GC2ehqjiA4Nhx0jqMmZW9ZTaAN5pGOEkEtIu/sQgnHcXPvFivF0tHL6NiJmssYuy5IR XXDhuPsqesb1SZzvXMD1A7uRWkSabc2CnwNuK0b0ypA60FrTP9vDcHV1uz0TUep9Qa1L dd5g== X-Gm-Message-State: APjAAAUEmKQ7zid4IcYqBwTqEd+kpm+LRExXGAhYExqCCbTQKoyQ5qsu zzKy+9MlqZ8RJglpxpw2XOpfcg== X-Google-Smtp-Source: APXvYqyxzxBugxiQhWjrcdKq/fapHz7ohmS/zaFmnasZqb/cpP6OqZNVRoAvo3fcsrgg1N6/7uR0JQ== X-Received: by 2002:a65:564b:: with SMTP id m11mr8264583pgs.133.1571437186710; Fri, 18 Oct 2019 15:19:46 -0700 (PDT) Received: from vader ([2620:10d:c090:200::2:cf85]) by smtp.gmail.com with ESMTPSA id o185sm11976062pfg.136.2019.10.18.15.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2019 15:19:46 -0700 (PDT) Date: Fri, 18 Oct 2019 15:19:45 -0700 From: Omar Sandoval To: Nikolay Borisov Cc: linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@fb.com, Dave Chinner , Jann Horn , linux-api@vger.kernel.org Subject: Re: [RFC PATCH v2 3/5] btrfs: generalize btrfs_lookup_bio_sums_dio() Message-ID: <20191018221945.GB59713@vader> References: <01fdb646d7572f7d0d123937835db5c605e25a5e.1571164762.git.osandov@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Oct 16, 2019 at 12:22:33PM +0300, Nikolay Borisov wrote: > > > On 15.10.19 г. 21:42 ч., Omar Sandoval wrote: > > From: Omar Sandoval > > > > This isn't actually dio-specific; it just looks up the csums starting at > > the given offset instead of using the page index. Rename it to > > btrfs_lookup_bio_sums_at_offset() and add the dst parameter. We might > > even want to expose __btrfs_lookup_bio_sums() as the public API instead > > of having two trivial wrappers, but I'll leave that for another day. > > IMO exposing btrfs_lookup_bio_sums and adding proper kernel doc for its > parameters is the correct way forward. Consider doing this if the > general direction of this patchset is accepted and before sending the > final revision. Ok, if I'm not the only one that thinks it's a good idea, I'll go ahead with that.