From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Do not check for writeback in btrfs_releasepage()
Date: Fri, 18 Oct 2019 18:35:45 -0500 [thread overview]
Message-ID: <20191018233545.5kguaw4cjyrcsxwj@fiona> (raw)
In-Reply-To: <20191018181544.26515-2-rgoldwyn@suse.de>
Scratch this. btrfs_releasepage() is called from btrfs_invalidatepage()
as well. Sorry for the noise.
On 13:15 18/10, Goldwyn Rodrigues wrote:
> From: Goldwyn Rodrigues <rgoldwyn@suse.com>
>
> We check for PageWriteback in try_to_release_page(), the
> sole caller of address_space->releasepage(). We don't need
> to check it again in btrfs_releasepage()
>
> Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> ---
> fs/btrfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 0f2754eaa05b..10303c2379a9 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -8793,7 +8793,7 @@ static int __btrfs_releasepage(struct page *page, gfp_t gfp_flags)
>
> static int btrfs_releasepage(struct page *page, gfp_t gfp_flags)
> {
> - if (PageWriteback(page) || PageDirty(page))
> + if (PageDirty(page))
> return 0;
> return __btrfs_releasepage(page, gfp_flags);
> }
> --
> 2.16.4
>
--
Goldwyn
next prev parent reply other threads:[~2019-10-18 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 18:15 [PATCH] btrfs: Do not check for PagePrivate twice Goldwyn Rodrigues
2019-10-18 18:15 ` [PATCH] btrfs: Do not check for writeback in btrfs_releasepage() Goldwyn Rodrigues
2019-10-18 23:35 ` Goldwyn Rodrigues [this message]
2019-10-21 9:52 ` [PATCH] btrfs: Do not check for PagePrivate twice Filipe Manana
2019-11-28 11:44 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018233545.5kguaw4cjyrcsxwj@fiona \
--to=rgoldwyn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).