From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3CCCCA9EB0 for ; Mon, 21 Oct 2019 18:05:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BA08521906 for ; Mon, 21 Oct 2019 18:05:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="mIsrtuZI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730049AbfJUSF0 (ORCPT ); Mon, 21 Oct 2019 14:05:26 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:33054 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730041AbfJUSFZ (ORCPT ); Mon, 21 Oct 2019 14:05:25 -0400 Received: by mail-pf1-f193.google.com with SMTP id q10so8922863pfl.0 for ; Mon, 21 Oct 2019 11:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+qMv7Aq/EKWcqrxVLodIHRmz/ZNgPTOxblOtF0zmUyA=; b=mIsrtuZI2pu1seVtPlHpFnpNq+53C91o7GSE9m8ZZybgJznhZYmp7QTkGlNqwNeFSS 2uhxou+IVzBM5+QFoaY8QhGw4uUKqPHrCzXZz1p7VXVUk/KvNqucynnGFl+YWiQVnA7s n92vAF01jaMsePBRl2+TS53rKcJSilmCX+gDbBTE+YFiAh1ylXDHQ0ldqmO5Iadul4DE lhinrgTVgse144a3Y1Fo4tILDk+oEe4XKklmBPdSEX+M79ZZ7R6rM5u+Mbv6ikXBoE9j M3BhuQ/NSOOEdbgxDNWtbRH8eJGymYBxle2X6yFH3E027XXR/U0SmN79UgFroryXLN/8 pX1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+qMv7Aq/EKWcqrxVLodIHRmz/ZNgPTOxblOtF0zmUyA=; b=LT0ey96NpTAx3V12nfTBgVhGKm1dajsTfVq10DNt4wP8itOIUffvi4KpM+EI747DtO ndRBMFCB/Qvlo6b40HiLYhkG+Mr/wVoCPQ4aCC2GoVVfR9CixacrjFSTBzzY7y8vDb7J yGrJm+qs58Q5dF8XhYIuywEi2LIlQoI+JRjs9Ld7QsXn37G+k37xm7ofecVBCn0yK6mF erQPebYYVfzXjeD70o5nFw18H2FIky/DPHns68UB1ae1A0crVKshnNKF7GSx0nwIEnjW djM87ExTnC7XOy2eY+RbLrcmaWK43+DXqyh+kptLSSy1ZrBwNULjKiAiWNZA2cqJ1ttQ lhRg== X-Gm-Message-State: APjAAAWIgnpCzeNjp0o319AwGm6wiAGvYIACzYl72KoY19st1NzfEEWP lUd4FqMTgmoIO75PCFXPZ/WAcQ== X-Google-Smtp-Source: APXvYqzxVOSpakbgchAj/0P4pwxdp36727zPto9TUN70iw399TJ9wp8rkaQTKKWIbUxovXt9MA4Lrg== X-Received: by 2002:a65:638a:: with SMTP id h10mr26701649pgv.388.1571681123766; Mon, 21 Oct 2019 11:05:23 -0700 (PDT) Received: from vader ([2620:10d:c090:200::3:4637]) by smtp.gmail.com with ESMTPSA id k31sm17586704pjb.14.2019.10.21.11.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 11:05:22 -0700 (PDT) Date: Mon, 21 Oct 2019 11:05:22 -0700 From: Omar Sandoval To: dsterba@suse.cz, Nikolay Borisov , linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@fb.com, Dave Chinner , Jann Horn , linux-api@vger.kernel.org Subject: Re: [RFC PATCH v2 5/5] btrfs: implement RWF_ENCODED writes Message-ID: <20191021180522.GA81648@vader> References: <904de93d9bbe630aff7f725fd587810c6eb48344.1571164762.git.osandov@fb.com> <0da91628-7f54-7d24-bf58-6807eb9535a5@suse.com> <20191018225513.GD59713@vader> <20191021131452.GH3001@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191021131452.GH3001@twin.jikos.cz> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Oct 21, 2019 at 03:14:52PM +0200, David Sterba wrote: > On Fri, Oct 18, 2019 at 03:55:13PM -0700, Omar Sandoval wrote: > > > > + nr_pages = (disk_num_bytes + PAGE_SIZE - 1) >> PAGE_SHIFT; > > > > > > nit: nr_pages = DIV_ROUND_UP(disk_num_bytes, PAGE_SIZE) > > > > disk_num_bytes is a u64, so that would expand to a 64-bit division. The > > compiler is probably smart enough to optimize it to a shift, but I > > didn't want to rely on that, because that would cause build failures on > > 32-bit. > > There are several DIV_ROUND_UP(u64, PAGE_SIZE) in btrfs code, no build > brekages have been reported so far, you can use it. Good to know, I'll fix both places I'm doing this, then.