* [PATCH v2] btrfs: Remove btrfs_bio::flags member
@ 2019-10-24 1:38 Qu Wenruo
2019-10-24 11:17 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Qu Wenruo @ 2019-10-24 1:38 UTC (permalink / raw)
To: linux-btrfs
This member is not used by any one, just remove it.
And since it's between two pointers, such removal should save us a
pointer size of the structure.
The last user of btrfs_bio::flags is removed in commit 326e1dbb5736
("block: remove management of bi_remaining when restoring original
bi_end_io").
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
Changelog:
v2:
- Mention the when last user of btrfs_bio::flags is removed.
- Don't mention btrfs_bio::map_type in commit message.
Since btrfs_bio::flags is for another purpose, it has nothing to do
with btrfs_bio::map_type.
---
fs/btrfs/volumes.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index a7da1f3e3627..5acf5c507ec2 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -330,7 +330,6 @@ struct btrfs_bio {
u64 map_type; /* get from map_lookup->type */
bio_end_io_t *end_io;
struct bio *orig_bio;
- unsigned long flags;
void *private;
atomic_t error;
int max_errors;
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] btrfs: Remove btrfs_bio::flags member
2019-10-24 1:38 [PATCH v2] btrfs: Remove btrfs_bio::flags member Qu Wenruo
@ 2019-10-24 11:17 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2019-10-24 11:17 UTC (permalink / raw)
To: Qu Wenruo; +Cc: linux-btrfs
On Thu, Oct 24, 2019 at 09:38:29AM +0800, Qu Wenruo wrote:
> This member is not used by any one, just remove it.
>
> And since it's between two pointers, such removal should save us a
> pointer size of the structure.
>
> The last user of btrfs_bio::flags is removed in commit 326e1dbb5736
> ("block: remove management of bi_remaining when restoring original
> bi_end_io").
Oh, that's an old patch, 2015. I'll add a stable tag though it's not a
fix but the size reduction of a frequently used structure is a good
thing. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-24 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 1:38 [PATCH v2] btrfs: Remove btrfs_bio::flags member Qu Wenruo
2019-10-24 11:17 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).