From: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: dsterba@suse.com, linux-btrfs@vger.kernel.org,
mpdesouza@suse.com, anand.jain@oracle.com
Subject: [PATCH btrfs-progs 1/2] btrfs-progs: balance: Don't set stderr to /dev/null on balance_start
Date: Wed, 30 Oct 2019 20:36:40 -0300 [thread overview]
Message-ID: <20191030233641.30123-2-marcos.souza.org@gmail.com> (raw)
In-Reply-To: <20191030233641.30123-1-marcos.souza.org@gmail.com>
From: Marcos Paulo de Souza <mpdesouza@suse.com>
Remove the close/open calls in order to receive the error messages when
starting balance in the background.
Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
---
cmds/balance.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/cmds/balance.c b/cmds/balance.c
index 32830002..f0394a2e 100644
--- a/cmds/balance.c
+++ b/cmds/balance.c
@@ -659,10 +659,8 @@ static int cmd_balance_start(const struct cmd_struct *cmd,
i = chdir("/");
close(0);
close(1);
- close(2);
open("/dev/null", O_RDONLY);
open("/dev/null", O_WRONLY);
- open("/dev/null", O_WRONLY);
break;
default:
exit(0);
--
2.23.0
next prev parent reply other threads:[~2019-10-30 23:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 23:36 [PATCH btrfs-progs 0/2] balance: check balance errors on background Marcos Paulo de Souza
2019-10-30 23:36 ` Marcos Paulo de Souza [this message]
2019-10-30 23:36 ` [PATCH btrfs-progs 2/2] btrfs-progs: balance: Verify EINPROGRESS on background balance Marcos Paulo de Souza
2019-10-31 10:00 ` [PATCH btrfs-progs 0/2] balance: check balance errors on background Anand Jain
2019-11-15 12:18 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030233641.30123-2-marcos.souza.org@gmail.com \
--to=marcos.souza.org@gmail.com \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mpdesouza@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).