From: David Sterba <dsterba@suse.cz>
To: dsterba@suse.cz, Qu WenRuo <wqu@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Johannes Thumshirn <jthumshirn@suse.de>,
Anand Jain <anand.jain@oracle.com>
Subject: Re: [PATCH v3 2/3] btrfs: block-group: Refactor btrfs_read_block_groups()
Date: Mon, 4 Nov 2019 22:44:24 +0100 [thread overview]
Message-ID: <20191104214424.GH3001@twin.jikos.cz> (raw)
In-Reply-To: <20191104195352.GE3001@twin.jikos.cz>
On Mon, Nov 04, 2019 at 08:53:52PM +0100, David Sterba wrote:
> On Wed, Oct 30, 2019 at 04:59:17AM +0000, Qu WenRuo wrote:
> >
> >
> > On 2019/10/10 上午10:39, Qu Wenruo wrote:
> > > Refactor the work inside the loop of btrfs_read_block_groups() into one
> > > separate function, read_one_block_group().
> > >
> > > This allows read_one_block_group to be reused for later BG_TREE feature.
> > >
> > > The refactor does the following extra fix:
> > > - Use btrfs_fs_incompat() to replace open-coded feature check
> > >
> > > Signed-off-by: Qu Wenruo <wqu@suse.com>
> > > Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> > > Reviewed-by: Anand Jain <anand.jain@oracle.com>
> >
> > Hi David,
> >
> > Mind to add this patch to for-next branch?
> >
> > Considering the recent changes to struct btrfs_block_group_cache, there
> > is some considerable conflicts.
>
> I see, as the patch is idependent I'll add it.
>
> > It would be much easier to solve them sooner than later.
> > If needed I could send a newer version based on latest for-next branch.
>
> I've fixed the conflicts, but please have a look anyway. The change was
> cache->item to local block group item and rename of found_key to key in
> read_one_block_group.
And it crashes during the self-tests, the patch is in branch
misc-next-with-bg-refactoring in my github tree, please have a look.
I've removed it from misc-next for now as I need to test for-next, but
it's probably going to be some trivial typo so the patch will be added
once it's found. Thanks.
next prev parent reply other threads:[~2019-11-04 21:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 2:39 [PATCH v3 0/3] btrfs: Introduce new incompat feature BG_TREE to hugely reduce mount time Qu Wenruo
2019-10-10 2:39 ` [PATCH v3 1/3] btrfs: block-group: Fix a memory leak due to missing btrfs_put_block_group() Qu Wenruo
2019-10-10 2:51 ` Anand Jain
2019-10-10 7:20 ` Johannes Thumshirn
2019-10-11 19:23 ` David Sterba
2019-10-10 2:39 ` [PATCH v3 2/3] btrfs: block-group: Refactor btrfs_read_block_groups() Qu Wenruo
2019-10-10 2:52 ` Anand Jain
2019-10-30 4:59 ` Qu WenRuo
2019-11-04 19:53 ` David Sterba
2019-11-04 21:44 ` David Sterba [this message]
2019-11-05 0:47 ` Qu Wenruo
2019-11-04 19:55 ` David Sterba
2019-10-10 2:39 ` [PATCH v3 3/3] btrfs: Introduce new incompat feature, BG_TREE, to speed up mount time Qu Wenruo
2019-10-10 5:21 ` Naohiro Aota
2019-10-11 13:23 ` Josef Bacik
2019-10-14 9:08 ` Anand Jain
2019-10-10 2:40 ` [PATCH v3 0/3] btrfs: Introduce new incompat feature BG_TREE to hugely reduce " Qu WenRuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104214424.GH3001@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).