From: "Andreas Färber" <afaerber@suse.de>
To: Qu Wenruo <wqu@suse.com>, David Sterba <dsterba@suse.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
linux-btrfs@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH next 0/2] btrfs: Fix build warnings for arm
Date: Fri, 8 Nov 2019 22:38:51 +0100 [thread overview]
Message-ID: <20191108213853.16635-1-afaerber@suse.de> (raw)
Hello Wenruo and Dave,
This mini-series fixes two build warnings found while cross-compiling for arm,
using openSUSE's cross-arm-binutils and cross-arm-none-gcc9 packages.
Replacing BUG_ON() with btrfs_crit() error handling is noble work, but please
be careful not to hardcode format specifiers for x86_64's size_t.
https://www.kernel.org/doc/Documentation/printk-formats.txt
In one case it could've been noticed during review, in another it was hidden
through a macro and would've only been found through compile-testing.
Probably a 32-bit i386 build would do; otherwise ARCH=arm multi_v7_defconfig
plus CONFIG_BTRFS_FS should reproduce.
It's around for maybe three weeks, so I wonder why kbuild bot didn't catch it.
Cheers,
Andreas
Andreas Färber (2):
btrfs: tree-checker: Fix error format string
btrfs: extent-tree: Fix error format string
fs/btrfs/extent-tree.c | 2 +-
fs/btrfs/tree-checker.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.16.4
next reply other threads:[~2019-11-08 21:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 21:38 Andreas Färber [this message]
2019-11-08 21:38 ` [PATCH next 1/2] btrfs: tree-checker: Fix error format string Andreas Färber
2019-11-11 18:31 ` David Sterba
2019-11-26 10:36 ` Geert Uytterhoeven
2019-11-26 15:44 ` David Sterba
2019-11-08 21:38 ` [PATCH next 2/2] btrfs: extent-tree: " Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108213853.16635-1-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=jthumshirn@suse.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).