From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
David Sterba <dsterba@suse.com>,
Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 5/5] btrfs: remove final BUG_ON() in close_fs_devices()
Date: Tue, 12 Nov 2019 13:55:24 +0100 [thread overview]
Message-ID: <20191112125524.GX3001@twin.jikos.cz> (raw)
In-Reply-To: <f474ee05-5343-3a52-5e79-d4199828a8ee@gmx.com>
On Tue, Nov 12, 2019 at 08:41:50PM +0800, Qu Wenruo wrote:
>
>
> On 2019/11/12 下午8:24, Johannes Thumshirn wrote:
> > Now that the preparation work is done, remove the temporary BUG_ON() in
> > close_fs_devices() and return an error instead.
> >
> > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>
> > ---
> > fs/btrfs/volumes.c | 7 ++++++-
> > 1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> > index be1fd935edf7..844333b96075 100644
> > --- a/fs/btrfs/volumes.c
> > +++ b/fs/btrfs/volumes.c
> > @@ -1128,7 +1128,12 @@ static int close_fs_devices(struct btrfs_fs_devices *fs_devices)
> > mutex_lock(&fs_devices->device_list_mutex);
> > list_for_each_entry_safe(device, tmp, &fs_devices->devices, dev_list) {
> > ret = btrfs_close_one_device(device);
> > - BUG_ON(ret); /* -ENOMEM */
> > + if (ret) {
> > + mutex_unlock(&fs_devices->device_list_mutex);
> > + return ret;
> > + }
> > + fs_devices->opened--;
> > + fs_devices->seeding--;
>
> This seeding-- doesn't look safe to me.
Yeah, same here, it could be correct in the sense that it's 1 -> 0
exactly once, but otherwise its a bool, and handled in a special way.
next prev parent reply other threads:[~2019-11-12 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 12:24 [PATCH 0/5] remove BUG_ON()s in btrfs_close_one_device() Johannes Thumshirn
2019-11-12 12:24 ` [PATCH 1/5] btrfs: decrement number of open devices after closing the device not before Johannes Thumshirn
2019-11-12 12:24 ` [PATCH 2/5] btrfs: handle device allocation failure in btrfs_close_one_device() Johannes Thumshirn
2019-11-12 12:24 ` [PATCH 3/5] btrfs: handle allocation failure in strdup Johannes Thumshirn
2019-11-12 12:24 ` [PATCH 4/5] btrfs: handle error return of close_fs_devices() Johannes Thumshirn
2019-11-12 12:24 ` [PATCH 5/5] btrfs: remove final BUG_ON() in close_fs_devices() Johannes Thumshirn
2019-11-12 12:41 ` Qu Wenruo
2019-11-12 12:55 ` David Sterba [this message]
2019-11-12 12:59 ` Johannes Thumshirn
2019-11-12 12:40 ` [PATCH 0/5] remove BUG_ON()s in btrfs_close_one_device() Qu Wenruo
2019-11-12 12:57 ` Johannes Thumshirn
2019-11-12 12:49 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112125524.GX3001@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dsterba@suse.com \
--cc=jthumshirn@suse.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).