From: David Sterba <dsterba@suse.cz>
To: Nikolay Borisov <nborisov@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: Fix error messages in qgroup_rescan_init
Date: Tue, 19 Nov 2019 13:45:55 +0100 [thread overview]
Message-ID: <20191119124554.GS3001@twin.jikos.cz> (raw)
In-Reply-To: <20191118121644.15289-1-nborisov@suse.com>
On Mon, Nov 18, 2019 at 02:16:44PM +0200, Nikolay Borisov wrote:
> The branch of qgroup_rescan_init which is executed from the mount
> path prints wrong errors messages. The textual print out in case
> BTRFS_QGROUP_STATUS_FLAG_RESCAN/BTRFS_QGROUP_STATUS_FLAG_ON are not
> set are transposed. Fix it by exchanging their place.
While that's fixing the swapped messages, I'm considering dropping some
of the messages completely. Eg. the warning 'rescan in progress' seems
useless because why I as a user should be notified about that? If I run
rescan twice and it's still in progress, there's no problem. And with
similar usability reasoning, look at the messages and drop them
eventually.
The specific messages were added by Qu in 9593bf49675ef, to improve the
message that printed function name and error code. That was an
improvement but now I'm questioning the utility of the messages.
next prev parent reply other threads:[~2019-11-19 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 12:16 [PATCH] btrfs: Fix error messages in qgroup_rescan_init Nikolay Borisov
2019-11-19 12:45 ` David Sterba [this message]
2019-11-19 12:50 ` Nikolay Borisov
2019-11-19 13:32 ` Qu Wenruo
2019-11-19 16:24 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119124554.GS3001@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).