From: David Sterba <dsterba@suse.cz>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Nikolay Borisov <nborisov@suse.com>,
Josef Bacik <josef@toxicpanda.com>,
Anand Jain <anand.jain@oracle.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH AUTOSEL 4.19 071/219] btrfs: Check for missing device before bio submission in btrfs_map_bio
Date: Fri, 22 Nov 2019 12:33:37 +0100 [thread overview]
Message-ID: <20191122113337.GB3001@suse.cz> (raw)
In-Reply-To: <20191122054911.1750-64-sashal@kernel.org>
On Fri, Nov 22, 2019 at 12:46:43AM -0500, Sasha Levin wrote:
> From: Nikolay Borisov <nborisov@suse.com>
>
> [ Upstream commit fc8a168aa9ab1680c2bd52bf9db7c994e0f2524f ]
>
> Before btrfs_map_bio submits all stripe bios it does a number of checks
> to ensure the device for every stripe is present. However, it doesn't do
> a DEV_STATE_MISSING check, instead this is relegated to the lower level
> btrfs_schedule_bio (in the async submission case, sync submission
> doesn't check DEV_STATE_MISSING at all). Additionally
> btrfs_schedule_bios does the duplicate device->bdev check which has
> already been performed in btrfs_map_bio.
>
> This patch moves the DEV_STATE_MISSING check in btrfs_map_bio and
> removes the duplicate device->bdev check. Doing so ensures that no bio
> cloning/submission happens for both async/sync requests in the face of
> missing device. This makes the async io submission path slightly shorter
> in terms of instruction count. No functional changes.
^^^^^^^^^^^^^^^^^^^^^
This should be a strong indication that the patch is not suitable for
autosel/stable, please remove it. Thanks.
next prev parent reply other threads:[~2019-11-22 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191122054911.1750-1-sashal@kernel.org>
2019-11-22 5:46 ` [PATCH AUTOSEL 4.19 071/219] btrfs: Check for missing device before bio submission in btrfs_map_bio Sasha Levin
2019-11-22 11:33 ` David Sterba [this message]
2019-11-22 5:46 ` [PATCH AUTOSEL 4.19 072/219] btrfs: fix ncopies raid_attr for RAID56 Sasha Levin
2019-11-22 5:46 ` [PATCH AUTOSEL 4.19 073/219] btrfs: dev-replace: set result code of cancel by status of scrub Sasha Levin
2019-11-22 5:46 ` [PATCH AUTOSEL 4.19 074/219] Btrfs: allow clear_extent_dirty() to receive a cached extent state record Sasha Levin
2019-11-22 5:46 ` [PATCH AUTOSEL 4.19 075/219] btrfs: only track ref_heads in delayed_ref_updates Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191122113337.GB3001@suse.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).