From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com, wqu@suse.com
Subject: [PATCH 0/4][RFC] clean up how we mark block groups read only
Date: Mon, 25 Nov 2019 09:40:07 -0500 [thread overview]
Message-ID: <20191125144011.146722-1-josef@toxicpanda.com> (raw)
Qu has been looking into ENOSPC during relocation and noticed some weirdness
with inc_block_group_ro. The problem is this code hasn't changed to keep up
with the rest of the reservation system. It still assumes that the amount of
space used will always be less than the total space for the space info, which
hasn't been true for years since I introduced overcommitting. This logic is
correct for DATA, but not for METADATA or SYSTEM.
The first few patches are just cleanups, and can probably be taken as is. The
final patch is the real meat of the problem to address Qu's issues. This is an
RFC because I'm elbow deep in another problem and haven't tested this beyond
compile testing, but I think it'll work. Once I've gotten a chance to test it
and Qu has tested it I'll update the list if it's good to go as is, or send a V2
with any changes. Thanks,
Josef
next reply other threads:[~2019-11-25 14:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 14:40 Josef Bacik [this message]
2019-11-25 14:40 ` [PATCH 1/4] btrfs: don't pass system_chunk into can_overcommit Josef Bacik
2019-11-25 15:36 ` Johannes Thumshirn
2019-11-26 2:32 ` Qu Wenruo
2019-11-26 8:42 ` Nikolay Borisov
2019-11-25 14:40 ` [PATCH 2/4] btrfs: kill min_allocable_bytes in inc_block_group_ro Josef Bacik
2019-11-26 2:35 ` Qu Wenruo
2019-11-25 14:40 ` [PATCH 3/4] btrfs: fix force usage " Josef Bacik
2019-11-26 2:43 ` Qu Wenruo
2019-11-26 4:59 ` Qu Wenruo
2019-11-26 10:09 ` Nikolay Borisov
2019-11-25 14:40 ` [PATCH 4/4] btrfs: use btrfs_can_overcommit " Josef Bacik
2019-11-26 3:00 ` Qu Wenruo
2019-11-26 16:28 ` Josef Bacik
2019-11-26 10:18 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125144011.146722-1-josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).