From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E53C432C0 for ; Wed, 27 Nov 2019 09:10:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 47D322070A for ; Wed, 27 Nov 2019 09:10:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=osandov-com.20150623.gappssmtp.com header.i=@osandov-com.20150623.gappssmtp.com header.b="0koaoRgT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726204AbfK0JKU (ORCPT ); Wed, 27 Nov 2019 04:10:20 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:45643 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726145AbfK0JKU (ORCPT ); Wed, 27 Nov 2019 04:10:20 -0500 Received: by mail-pg1-f195.google.com with SMTP id k1so10469827pgg.12 for ; Wed, 27 Nov 2019 01:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=b7QOe1FC70muESaz9+PbY6FufdbspFqUvVZugA4Sa+U=; b=0koaoRgTcCXSbsVMOueG/T1xOoCZjxRg7Ck1FnRhPBQpjQL8TDUssP74bTyJ8kO3Yo fdzH/H9Q2b0SAT8KoRvvHS8UbFWC20phZRtVdomf5sddxeyyRIBM6Wrq57nWYJksCyyB 5U/taeGmZu5+IwwgrxGaBIfpS3sr0RNemBeV6FUIMJdalnTTD1ZCbFxxVhMitRQ1sZaX sfMSyNK/R8AY2IfmxU2Av7kifDFIAWsqZvd84DsLXYyHo/bfHVhZQembtiw1xj+Z8zBp 3tzZ8NI7ztt06WFVwwLwums3NhoR2V2vyVzxwOxh5Nv0PYXJe7PFY/Fg/Hppfm7BHg7z sGbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=b7QOe1FC70muESaz9+PbY6FufdbspFqUvVZugA4Sa+U=; b=rSx8NFk40keT5fLFQeW77DdWD0UaH4xvsfb4nQXFrIC7PEW1Nx3yC0LFtmU4O3tPul OjlrsVK6OxvQfnbS/dc8vKIPm8IMKoDzUmO466yo5C735cLWRGnoU2R5s7ymmODAuVwA 14r+l2CBNL7kzX/ktdY5PgOHWn2YNYvjc0gDYrPL/LRaVbJKZUk7h5QbFEyE7ao00Ynr CM5mtGm/Chh9XcKRrKRk06to3WlgGS42YHEMY4rvEDyWKJjGaV/yBiQPKNBKrjpzeodL Cw+20KZFNhi1OGgeb9cdxnY1ym2s/26gu5wchScsOd5GxhOnMP0Kk3ZCimI8Z6Z8MHd9 iLEQ== X-Gm-Message-State: APjAAAVyrTqJ/fGNim0jxb6xI7TycbBEuHXVMp+PZD01lPNNmX9KduPb HC+8Kpu2w3VqoKpYVIfw1koBDQ== X-Google-Smtp-Source: APXvYqzy16Q7SuEKGV2/xSlWDFfb755gazILIRyDnfF1b2B7Nx18qVkR3Eu9ZcpFAzfP7Qq95Ey0OA== X-Received: by 2002:a65:55cc:: with SMTP id k12mr3818296pgs.184.1574845817569; Wed, 27 Nov 2019 01:10:17 -0800 (PST) Received: from vader ([2601:602:8b80:8e0:e6a7:a0ff:fe0b:c9a8]) by smtp.gmail.com with ESMTPSA id r203sm15762366pfr.184.2019.11.27.01.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 01:10:17 -0800 (PST) Date: Wed, 27 Nov 2019 01:10:14 -0800 From: Omar Sandoval To: Nikolay Borisov Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, Dave Chinner , Jann Horn , Amir Goldstein , Aleksa Sarai , linux-api@vger.kernel.org, kernel-team@fb.com Subject: Re: [RFC PATCH v3 03/12] fs: add RWF_ENCODED for reading/writing compressed data Message-ID: <20191127091014.GA745151@vader> References: <07f9cc1969052e94818fa50019e7589d206d1d18.1574273658.git.osandov@fb.com> <20191126173607.GA657777@vader> <73e9b52f-afed-fa0d-5463-222e41fead56@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <73e9b52f-afed-fa0d-5463-222e41fead56@suse.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Nov 27, 2019 at 11:00:15AM +0200, Nikolay Borisov wrote: > > > On 26.11.19 г. 19:36 ч., Omar Sandoval wrote: > > On Tue, Nov 26, 2019 at 03:53:02PM +0200, Nikolay Borisov wrote: > >> > >> > >> On 20.11.19 г. 20:24 ч., Omar Sandoval wrote: > >>> From: Omar Sandoval > >> > >> > >> > >>> > >>> +enum { > >>> + ENCODED_IOV_COMPRESSION_NONE, > >>> +#define ENCODED_IOV_COMPRESSION_NONE ENCODED_IOV_COMPRESSION_NONE > >>> + ENCODED_IOV_COMPRESSION_ZLIB, > >>> +#define ENCODED_IOV_COMPRESSION_ZLIB ENCODED_IOV_COMPRESSION_ZLIB > >>> + ENCODED_IOV_COMPRESSION_LZO, > >>> +#define ENCODED_IOV_COMPRESSION_LZO ENCODED_IOV_COMPRESSION_LZO > >>> + ENCODED_IOV_COMPRESSION_ZSTD, > >>> +#define ENCODED_IOV_COMPRESSION_ZSTD ENCODED_IOV_COMPRESSION_ZSTD > >>> + ENCODED_IOV_COMPRESSION_TYPES = ENCODED_IOV_COMPRESSION_ZSTD, > >> > >> This looks very dodgy, what am I missing? > > > > This is a somewhat common trick so that enum values can be checked for > > with ifdef/ifndef. See include/uapi/linux.in.h, for example. > > I cannot seem to have this file on my system (or any .in.h file for that > matter in the kernel source dir). Whoops, that should be include/uapi/linux/in.h