From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37921C432C0 for ; Thu, 28 Nov 2019 11:14:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1914721781 for ; Thu, 28 Nov 2019 11:14:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726734AbfK1LO0 (ORCPT ); Thu, 28 Nov 2019 06:14:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:54936 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726191AbfK1LOY (ORCPT ); Thu, 28 Nov 2019 06:14:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 220A5B189; Thu, 28 Nov 2019 11:14:23 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id C438CDAC01; Thu, 28 Nov 2019 12:14:20 +0100 (CET) Date: Thu, 28 Nov 2019 12:14:20 +0100 From: David Sterba To: Nikolay Borisov Cc: linux-btrfs@vger.kernel.org Subject: Re: [PATCH 3/3] btrfs: Rename __btrfs_free_reserved_extent to btrfs_pin_reserved_extent Message-ID: <20191128111420.GE2734@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Nikolay Borisov , linux-btrfs@vger.kernel.org References: <20191121120331.29070-1-nborisov@suse.com> <20191121120331.29070-4-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121120331.29070-4-nborisov@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Nov 21, 2019 at 02:03:31PM +0200, Nikolay Borisov wrote: > - ret = pin_down_extent(cache, start, len, 1); > + btrfs_add_free_space(cache, start, len); > + btrfs_free_reserved_bytes(cache, len, delalloc); > + trace_btrfs_reserved_extent_free(fs_info, start, len); Unrelated, this patch is only moving existing code, but btrfs_add_free_space and btrfs_free_reserved_bytes don't have their errors handled. In many other places too.