Linux-BTRFS Archive on
 help / color / Atom feed
From: Johannes Thumshirn <>
To: David Sterba <>
Cc: Nikolay Borisov <>, Qu Wenruo <>,
	Linux BTRFS Mailinglist <>,
	Johannes Thumshirn <>
Subject: [PATCH v5 0/2] remove BUG_ON()s in btrfs_close_one_device()
Date: Wed,  4 Dec 2019 14:36:37 +0100
Message-ID: <> (raw)

This series attempts to remove the BUG_ON()s in btrfs_close_one_device().
Therefore some reorganization of btrfs_close_one_device() was needed, to
avoid the memory allocation.

This series has passed fstests without any deviation from the baseline.

Changes to v4:
- Clear dev_stat_ccnt on removal (Dave)
  they'll be handled elsewhere
- Release extent_io_tree (fstests)

Changes to v3:
- Clear BTRFS_DEV_STATE_WRITEABLE after calling btrfs_close_bdev() so
  btrfs_close_bdev() can call sync_blockdev() and invalidate_bdev() (Nikolay)

Changes to v2:
- Completly different approach to the origianl patchset, instead of handling
  eventual allocation failures.
- Dropped already merged patches for ' btrfs_fs_devices::rotating' and
- Kept the 1st patch of the old series, as it's a nice cleanup

Changes to v1:
- Fixed the decremt of btrfs_fs_devices::seeding.
- In addition to this, I've added two patches changing btrfs_fs_devices::seeding
  and btrfs_fs_devices::rotating to bool, as they are in fact used as booleans.

Johannes Thumshirn (2):
  btrfs: decrement number of open devices after closing the device not
  btrfs: reset device back to allocation state when removing

 fs/btrfs/volumes.c | 31 ++++++++++++-------------------
 1 file changed, 12 insertions(+), 19 deletions(-)

2.20.1 (Apple Git-117)

             reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 13:36 Johannes Thumshirn [this message]
2019-12-04 13:36 ` [PATCH v5 1/2] btrfs: decrement number of open devices after closing the device not before Johannes Thumshirn
2019-12-04 13:36 ` [PATCH v5 2/2] btrfs: reset device back to allocation state when removing Johannes Thumshirn

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-BTRFS Archive on

Archives are clonable:
	git clone --mirror linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ \
	public-inbox-index linux-btrfs

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone