From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v3] Btrfs: fix missing data checksums after replaying a log tree
Date: Fri, 6 Dec 2019 16:30:10 +0100 [thread overview]
Message-ID: <20191206153010.GF2734@twin.jikos.cz> (raw)
In-Reply-To: <20191205165830.18477-1-fdmanana@kernel.org>
On Thu, Dec 05, 2019 at 04:58:30PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
[...]
> V2: Fixed changelog because it stated in the first paragraph that the problem
> affected only extents shared within the same file, but that's not true and
> contradicted the last paragraph. So fix that and state explicitly that it
> happens as well for extents shared between different files.
>
> V3: Drop existing checksums from the log during the fast fsync path as well.
> This is also needed to make the test case pass on kernels < 5.4 because
> on 5.4 the full sync bit is set on the inode whenever we clone, while
> before 5.4 we don't set it. The tree checker patch for detecting overlapping
> checksum items detected this during a fast fsync on generic/561 while
> running it in a loop for several hours.
Patch replaced, thanks.
prev parent reply other threads:[~2019-12-06 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 15:13 [PATCH 1/2] Btrfs: fix missing data checksums after replaying a log tree fdmanana
2019-12-02 11:00 ` [PATCH v2 " fdmanana
2019-12-03 18:51 ` David Sterba
2019-12-05 16:58 ` [PATCH v3] " fdmanana
2019-12-06 15:30 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206153010.GF2734@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).