From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/5] Various fixes
Date: Mon, 9 Dec 2019 19:16:18 +0100 [thread overview]
Message-ID: <20191209181618.GP2734@twin.jikos.cz> (raw)
In-Reply-To: <20191206143718.167998-1-josef@toxicpanda.com>
On Fri, Dec 06, 2019 at 09:37:13AM -0500, Josef Bacik wrote:
> These were discovered while reworking how we handle root refs. They are all
> relatively straightforward and mostly deal with error cases, with the exception
> of
>
> [PATCH 1/5] btrfs: drop log root for dropped roots
> [PATCH 4/5] btrfs: skip log replay on orphaned roots
>
> These two are pretty important and were uncovered with my fsstress patch. The
> first fixes a space leak in the case that we delete a subvol that has a tree log
> attached to it. The leak does not persist across mounts so it's not too bad,
> but still pretty important. The second patch I've only seen in production once
> in the last 90 days, but could keep us from mounting if we have a subvol that
> was deleted with a tree log that we didn't finish deleting.
>
> The rest of these are just for various error conditions and are less important,
> but should be safe enough to send along now if desired. Thanks,
2-5 added to misc-next, 1 has some comments. Thanks.
prev parent reply other threads:[~2019-12-09 18:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 14:37 [PATCH 0/5] Various fixes Josef Bacik
2019-12-06 14:37 ` [PATCH 1/5] btrfs: drop log root for dropped roots Josef Bacik
2019-12-06 15:02 ` Filipe Manana
2019-12-06 15:03 ` Nikolay Borisov
2019-12-09 17:39 ` David Sterba
2019-12-10 20:05 ` Josef Bacik
2019-12-10 21:19 ` Nikolay Borisov
2019-12-10 21:28 ` Josef Bacik
2019-12-13 15:17 ` David Sterba
2019-12-06 14:37 ` [PATCH 2/5] btrfs: don't BUG_ON in create_subvol Josef Bacik
2019-12-06 15:03 ` Filipe Manana
2019-12-09 10:49 ` Johannes Thumshirn
2019-12-06 14:37 ` [PATCH 3/5] btrfs: handle ENOENT in btrfs_uuid_tree_iterate Josef Bacik
2019-12-06 15:13 ` Filipe Manana
2019-12-06 15:17 ` Josef Bacik
2019-12-06 16:39 ` [PATCH 3/5][v2] " Josef Bacik
2019-12-06 16:46 ` Filipe Manana
2019-12-09 10:52 ` Johannes Thumshirn
2019-12-06 14:37 ` [PATCH 4/5] btrfs: skip log replay on orphaned roots Josef Bacik
2019-12-06 15:23 ` Filipe Manana
2019-12-06 14:37 ` [PATCH 5/5] btrfs: do not leak reloc root if we fail to read the fs root Josef Bacik
2019-12-06 15:24 ` Filipe Manana
2019-12-09 10:58 ` Johannes Thumshirn
2019-12-09 18:16 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209181618.GP2734@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).