From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C84EC2D0C2 for ; Mon, 30 Dec 2019 18:13:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D61D2206DB for ; Mon, 30 Dec 2019 18:13:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727490AbfL3SN1 (ORCPT ); Mon, 30 Dec 2019 13:13:27 -0500 Received: from mx2.suse.de ([195.135.220.15]:43308 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727389AbfL3SN1 (ORCPT ); Mon, 30 Dec 2019 13:13:27 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5245AAD45; Mon, 30 Dec 2019 18:13:25 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id AF2E0DA790; Mon, 30 Dec 2019 19:13:18 +0100 (CET) Date: Mon, 30 Dec 2019 19:13:18 +0100 From: David Sterba To: Dennis Zhou Cc: David Sterba , Chris Mason , Josef Bacik , Omar Sandoval , kernel-team@fb.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH v6 00/22] btrfs: async discard support Message-ID: <20191230181318.GC3929@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Dennis Zhou , David Sterba , Chris Mason , Josef Bacik , Omar Sandoval , kernel-team@fb.com, linux-btrfs@vger.kernel.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Fri, Dec 13, 2019 at 04:22:09PM -0800, Dennis Zhou wrote: > Hello, > > Dave reported a lockdep issue [1]. I'm a bit surprised as I can't repro > it, but it obviously is right. I believe I fixed the issue by moving the > fully trimmed check outside of the block_group lock. I mistakingly > thought the btrfs_block_group lock subsumed btrfs_free_space_ctl > tree_lock. This clearly isn't the case. > > Changes in v6: > - Move the fully trimmed check outside of the block_group lock. > > v5 is available here: [2]. > > This series is on top of btrfs-devel#misc-next 7ee98bb808e2 + [3] and > [4]. > > [1] https://lore.kernel.org/linux-btrfs/20191210140438.GU2734@twin.jikos.cz/ > [2] https://lore.kernel.org/linux-btrfs/cover.1575919745.git.dennis@kernel.org/ > [3] https://lore.kernel.org/linux-btrfs/d934383ea528d920a95b6107daad6023b516f0f4.1576109087.git.dennis@kernel.org/ > [4] https://lore.kernel.org/linux-btrfs/20191209193846.18162-1-dennis@kernel.org/ > > Dennis Zhou (22): > bitmap: genericize percpu bitmap region iterators > btrfs: rename DISCARD opt to DISCARD_SYNC > btrfs: keep track of which extents have been discarded > btrfs: keep track of cleanliness of the bitmap > btrfs: add the beginning of async discard, discard workqueue > btrfs: handle empty block_group removal > btrfs: discard one region at a time in async discard > btrfs: add removal calls for sysfs debug/ > btrfs: make UUID/debug have its own kobject > btrfs: add discard sysfs directory > btrfs: track discardable extents for async discard > btrfs: keep track of discardable_bytes > btrfs: calculate discard delay based on number of extents > btrfs: add bps discard rate limit > btrfs: limit max discard size for async discard > btrfs: make max async discard size tunable > btrfs: have multiple discard lists > btrfs: only keep track of data extents for async discard > btrfs: keep track of discard reuse stats > btrfs: add async discard header > btrfs: increase the metadata allowance for the free_space_cache > btrfs: make smaller extents more likely to go into bitmaps Patches 1-12 merged to a temporary misc-next but I haven't pushed it as misc-next yet (it's misc-next-with-discard-v6 in my github repo). There are some comments to patch 13 and up so please send them either as replies or as a shorter series. Thanks.