From: Kusanagi Kouichi <slash@ac.auone-net.jp>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: Implement lazytime
Date: Wed, 15 Jan 2020 22:41:06 +0900 [thread overview]
Message-ID: <20200115134106476.LBDG.46476.ppp.dion.ne.jp@dmta0009.auone-net.jp> (raw)
In-Reply-To: <7d0eadb4-5712-6fa1-f50f-f8ea6d8aea43@toxicpanda.com>
On 2020-01-14 05:44:33 -0800, Josef Bacik wrote:
> On 1/14/20 12:53 AM, Kusanagi Kouichi wrote:
> > I tested with xfstests and lazytime didn't cause any new failures.
> >
> > Signed-off-by: Kusanagi Kouichi <slash@ac.auone-net.jp>
> > ---
>
> We don't use the I_DIRTY flags for tracking our inodes, and .write_inode was
> removed because we didn't need it and it deadlocks. Thanks,
>
> Josef
Did you apply the patch and deadlock occur? According to commit 3c4276936f6f
("Btrfs: fix btrfs_write_inode vs delayed iput deadlock"), which removed
.write_inode, .write_inode calls btrfs_run_delayed_iputs and deadlock occurs.
But .write_inode in this patch doesn't seem to call btrfs_run_delayed_iputs.
next prev parent reply other threads:[~2020-01-15 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 8:53 [PATCH] btrfs: Implement lazytime Kusanagi Kouichi
2020-01-14 13:44 ` Josef Bacik
2020-01-15 13:41 ` Kusanagi Kouichi [this message]
2020-01-14 21:21 ` David Sterba
2020-01-15 13:45 ` Kusanagi Kouichi
2020-01-15 16:31 ` David Sterba
2020-01-16 18:01 ` Kusanagi Kouichi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115134106476.LBDG.46476.ppp.dion.ne.jp@dmta0009.auone-net.jp \
--to=slash@ac.auone-net.jp \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).