From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B554C33CB3 for ; Thu, 16 Jan 2020 18:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 385DB2073A for ; Thu, 16 Jan 2020 18:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579198594; bh=6iE2ejbYV4EdgBFaKfGUn3r49RQtWONk5VeROMmONp4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=0XR31nvqXzqkovbBpIS78hT5C2pkE9hBHcN+LSaQKls661mEIzH99b2NErUf8V7wN rzeVnwcCF+sqIJLTExZXah2eNCHQyuOdbxWTVLt7tQ4Hh3wV01sP3SJc7SrudKOJ/B VlvK2vxez+fQ5fD8+6oVMno2pEuD0GmHFBKMw6Xo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392935AbgAPSQd (ORCPT ); Thu, 16 Jan 2020 13:16:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:41230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392708AbgAPR3Z (ORCPT ); Thu, 16 Jan 2020 12:29:25 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF8D62470C; Thu, 16 Jan 2020 17:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195765; bh=6iE2ejbYV4EdgBFaKfGUn3r49RQtWONk5VeROMmONp4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ec+I362Th0RYFZpLLUldyebj5ShU+uxr+1mtcIMUsEhgGZ1iuZLx7Deb/3kXB28TK 4blwzyGSBipiqNUa3aY9/+YE38OUWqeo+SD8eXcyZupXQCkMTQfFeb5Zy08ZPoEtP7 6j/ZRFeC7N+mr4sCWMXR4yBxx19r5e7NOx3A35dI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Filipe Manana , Nikolay Borisov , David Sterba , Sasha Levin , linux-btrfs@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 293/371] Btrfs: fix inode cache waiters hanging on path allocation failure Date: Thu, 16 Jan 2020 12:22:45 -0500 Message-Id: <20200116172403.18149-236-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org From: Filipe Manana [ Upstream commit 9d123a35d7e97bb2139747b16127c9b22b6a593e ] If the caching thread fails to allocate a path, it returns without waking up any cache waiters, leaving them hang forever. Fix this by following the same approach as when we fail to start the caching thread: print an error message, disable inode caching and make the wakers fallback to non-caching mode behaviour (calling btrfs_find_free_objectid()). Fixes: 581bb050941b4f ("Btrfs: Cache free inode numbers in memory") Reviewed-by: Nikolay Borisov Signed-off-by: Filipe Manana Signed-off-by: David Sterba Signed-off-by: Sasha Levin --- fs/btrfs/inode-map.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode-map.c b/fs/btrfs/inode-map.c index b1c3a4ec76c8..2ae32451fb5b 100644 --- a/fs/btrfs/inode-map.c +++ b/fs/btrfs/inode-map.c @@ -55,8 +55,10 @@ static int caching_kthread(void *data) return 0; path = btrfs_alloc_path(); - if (!path) + if (!path) { + fail_caching_thread(root); return -ENOMEM; + } /* Since the commit root is read-only, we can safely skip locking. */ path->skip_locking = 1; -- 2.20.1