From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] btrfs: Add comment for BTRFS_ROOT_REF_COWS
Date: Wed, 12 Feb 2020 15:46:51 +0800 [thread overview]
Message-ID: <20200212074651.33008-1-wqu@suse.com> (raw)
This bit is being used in too many locations while there is still no
good enough explaination for how this bit is used.
Not to mention its name really doesn't make much sense.
So this patch will add my explanation on this bit, considering only
subvolume trees, along with its reloc trees have this bit, to me it
looks like this bit shows whether tree blocks of a root can be shared.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/ctree.h | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/fs/btrfs/ctree.h b/fs/btrfs/ctree.h
index 36df977b64d9..61ab6e8c9a18 100644
--- a/fs/btrfs/ctree.h
+++ b/fs/btrfs/ctree.h
@@ -971,6 +971,15 @@ enum {
* is used to tell us when more checks are required
*/
BTRFS_ROOT_IN_TRANS_SETUP,
+
+ /*
+ * Whether tree blocks of a root can be shared.
+ *
+ * All subvolume trees, and their reloc trees, have this bit set.
+ *
+ * While all other trees, including essential trees like root, csum,
+ * extent, chunk trees, and log trees don't have this bit set.
+ */
BTRFS_ROOT_REF_COWS,
BTRFS_ROOT_TRACK_DIRTY,
BTRFS_ROOT_IN_RADIX,
--
2.25.0
next reply other threads:[~2020-02-12 7:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 7:46 Qu Wenruo [this message]
2020-02-12 13:04 ` [PATCH] btrfs: Add comment for BTRFS_ROOT_REF_COWS Josef Bacik
2020-02-14 16:53 ` David Sterba
2020-02-17 7:06 ` Qu Wenruo
2020-05-11 8:09 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212074651.33008-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).