From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: bail out of uuid tree scanning if we're closing
Date: Fri, 21 Feb 2020 18:09:31 +0100 [thread overview]
Message-ID: <20200221170931.GP2902@twin.jikos.cz> (raw)
In-Reply-To: <20200214200501.2524-1-josef@toxicpanda.com>
On Fri, Feb 14, 2020 at 03:05:01PM -0500, Josef Bacik wrote:
> In doing my fsstress+EIO stress testing I started running into issues
> where umount would get stuck forever because the uuid checker was
> chewing through the thousands of subvolumes I had created. We shouldn't
> block umount on this, simply bail if we're unmounting the fs. We need
> to make sure we don't mark the UUID tree as ok, so we only set that bit
> if we made it through the whole rescan operation, but otherwise this is
> completely safe.
>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Added to misc-next, thanks.
prev parent reply other threads:[~2020-02-21 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 20:05 [PATCH] btrfs: bail out of uuid tree scanning if we're closing Josef Bacik
2020-02-17 8:11 ` Johannes Thumshirn
2020-02-21 17:09 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200221170931.GP2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).