Linux-BTRFS Archive on lore.kernel.org
 help / color / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH] btrfs: set update the uuid generation as soon as possible
Date: Fri, 21 Feb 2020 18:16:17 +0100
Message-ID: <20200221171617.GQ2902@twin.jikos.cz> (raw)
In-Reply-To: <20200214202206.1642-1-josef@toxicpanda.com>

On Fri, Feb 14, 2020 at 03:22:06PM -0500, Josef Bacik wrote:
> In my EIO stress testing I noticed I was getting forced to rescan the
> uuid tree pretty often, which was weird.  This is because my error
> injection stuff would sometimes inject an error after log replay but
> before we loaded the UUID tree.  If log replay committed the transaction
> it wouldn't have updated the uuid tree generation, but the tree was
> valid and didn't change, so there's no reason to not update the
> generation here.
> 
> Fix this by setting the BTRFS_FS_UPDATE_UUID_TREE_GEN bit immediately
> after reading all the fs roots if the uuid tree generation matches the
> fs generation.  Then any transaction commits that happen during mount
> won't screw up our uuid tree state, forcing us to do needless uuid
> rescans.
> 
> Fixes: 70f801754728 ("Btrfs: check UUID tree during mount if required")
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>

Added to misc-next, thanks.

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-14 20:22 Josef Bacik
2020-02-21 17:16 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200221171617.GQ2902@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=josef@toxicpanda.com \
    --cc=kernel-team@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-BTRFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \
		linux-btrfs@vger.kernel.org
	public-inbox-index linux-btrfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git