From: David Sterba <dsterba@suse.cz>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs-progs: dump-tree: Introduce --nofilename option
Date: Wed, 4 Mar 2020 16:35:59 +0100 [thread overview]
Message-ID: <20200304153559.GW2902@twin.jikos.cz> (raw)
In-Reply-To: <20191115155207.GW3001@twin.jikos.cz>
On Fri, Nov 15, 2019 at 04:52:07PM +0100, David Sterba wrote:
> On Mon, Nov 11, 2019 at 03:24:35PM +0800, Qu Wenruo wrote:
> > In the mail list, it's pretty common that a developer is asking dump tree
> > output from the reporter, it's better to protect those kind reporters by
> > hiding the filename if the reporter wants.
>
> That's useful. Can we name it '--hide-filenames' ? You describe it in
> the text and I think this expresses what it does and hopefully will be
> clear to random users what the options does.
> Idea to consider: print a placeholder, like "name: HIDDEN", to keep the
> format of dump the same. It can also simplify the code.
So with the above implemented, the option is now --hide-names and prints
HIDDEN instead of various names.
prev parent reply other threads:[~2020-03-04 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 7:24 [PATCH] btrfs-progs: dump-tree: Introduce --nofilename option Qu Wenruo
2019-11-15 15:52 ` David Sterba
2020-03-04 15:35 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200304153559.GW2902@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).