From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/8][v2] relocation error handling fixes
Date: Fri, 13 Mar 2020 15:35:47 +0100 [thread overview]
Message-ID: <20200313143547.GM12659@twin.jikos.cz> (raw)
In-Reply-To: <20200304161830.2360-1-josef@toxicpanda.com>
On Wed, Mar 04, 2020 at 11:18:22AM -0500, Josef Bacik wrote:
> v1->v2:
> - Incorporated the various feedback, tweaked some things, adjusted commit
> messages, added some more comments. Hopefully I got everything.
> - Added "btrfs: do not init a reloc root if we aren't relocating", this is to
> oddress the weird handling of DEAD_ROOT and the use-after-free that Qu had
> originally attempted to fix.
> - Reworked "btrfs: splice rc->reloc_roots onto reloc roots in recover" to simply
> handle cleaning up any remaining bigs on the reloc_control, since errors can
> mean we'll have some things left pending on the reloc_control.
I've merged the reviewed patches to misc-next, but there are still
comments to 4 and 6, while 7, 8 could be fine as-is, at least 7 depends
on 6 so it might need changes too.
This the last batch of fixes I want to get in before merging the root
refs part 2. Both are in for-next so we have some testing coverage, but
the changelog for patch 6 is really insufficient.
prev parent reply other threads:[~2020-03-13 14:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 16:18 [PATCH 0/8][v2] relocation error handling fixes Josef Bacik
2020-03-04 16:18 ` [PATCH 1/8] btrfs: drop block from cache on error in relocation Josef Bacik
2020-03-05 11:37 ` Qu Wenruo
2020-03-04 16:18 ` [PATCH 2/8] btrfs: do not init a reloc root if we aren't relocating Josef Bacik
2020-03-04 18:44 ` Nikolay Borisov
2020-03-04 18:47 ` Josef Bacik
2020-03-05 11:24 ` Qu Wenruo
2020-03-04 16:18 ` [PATCH 3/8] btrfs: unset reloc control if we fail to recover Josef Bacik
2020-03-05 11:38 ` Qu Wenruo
2020-03-04 16:18 ` [PATCH 4/8] btrfs: free the reloc_control in a consistent way Josef Bacik
2020-03-05 11:39 ` Qu Wenruo
2020-03-13 15:18 ` David Sterba
2020-03-13 15:32 ` Josef Bacik
2020-03-14 0:13 ` Qu Wenruo
2020-03-04 16:18 ` [PATCH 5/8] btrfs: run clean_dirty_subvols if we fail to start a trans Josef Bacik
2020-03-05 11:40 ` Qu Wenruo
2020-03-05 17:46 ` David Sterba
2020-03-04 16:18 ` [PATCH 6/8] btrfs: clear BTRFS_ROOT_DEAD_RELOC_TREE before dropping the reloc root Josef Bacik
2020-03-05 11:41 ` Qu Wenruo
2020-03-05 13:54 ` Josef Bacik
2020-03-04 16:18 ` [PATCH 7/8] btrfs: hold a ref on the root->reloc_root Josef Bacik
2020-03-04 16:18 ` [PATCH 8/8] btrfs: remove a BUG_ON() from merge_reloc_roots() Josef Bacik
2020-03-13 14:35 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313143547.GM12659@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).