From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH 0/4] Relocation and backref resolution fixes
Date: Fri, 13 Mar 2020 17:17:05 -0400 [thread overview]
Message-ID: <20200313211709.148967-1-josef@toxicpanda.com> (raw)
These are standalone fixes that came out of my debugging Zygo's problems. The
first two address a problem with how we handle restarting relocation.
Previously this rarely happened, because if it had people would have complained.
The restart logic was broken in a few subtle ways, and these two patches address
those issues.
The third patch just boggles my mind. We were recording reloc roots based on
their current bytenr. This worked fine if we never restarted, but broke if we
had to lookup a ref to a reloc root that we found on the tree. This is because
that would point at the commit root of the reloc root, but if we had modified
the reloc root we'd no longer be able to find it.
And finally the last one was a weird deadlock that Zygo's insane test rig found,
as he runs the dedup thing while balancing and deleting snapshots, which made
this thing fall out. Thanks,
Josef
next reply other threads:[~2020-03-13 21:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 21:17 Josef Bacik [this message]
2020-03-13 21:17 ` [PATCH 1/4] btrfs: move reserve_metadat_bytes up in relocate_tree_block Josef Bacik
2020-03-13 21:17 ` [PATCH 2/4] btrfs: restart relocate_tree_blocks properly Josef Bacik
2020-03-13 21:17 ` [PATCH 3/4] btrfs: track reloc roots based on their commit_root bytenr Josef Bacik
2020-03-13 21:17 ` [PATCH 4/4] btrfs: do not resolve backrefs for roots that are being deleted Josef Bacik
2020-03-25 14:01 ` [PATCH 0/4] Relocation and backref resolution fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200313211709.148967-1-josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).