Linux-BTRFS Archive on lore.kernel.org
 help / color / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/2] btrfs: balance root leak and runaway balance fix
Date: Fri, 22 May 2020 13:13:47 +0200
Message-ID: <20200522111347.GJ18421@twin.jikos.cz> (raw)
In-Reply-To: <20200520065851.12689-1-wqu@suse.com>

On Wed, May 20, 2020 at 02:58:49PM +0800, Qu Wenruo wrote:
> This patchset will fix the most wanted balance bug, runaway balance.
> All my fault, and all small fixes.

Well, that happens.

d2311e698578 ("btrfs: relocation: Delay reloc tree deletion after merge_reloc_roots")

is the most broken patch in recent history (5.1+), there were so many
fixups but hopefully this is the last one. I've tagged the patches for
5.1+ stable but we'll need manual backports due to the root refcount
changes in 5.7.

I reproduced the umount crash and verified the fix, the runaway balance
does not happen anymore in the test so I guess we have all the needed
fixes in place to allow the fast balance cancel. Thanks.

      parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20  6:58 Qu Wenruo
2020-05-20  6:58 ` [PATCH 1/2] btrfs: relocation: Fix reloc root leakage and the NULL pointer reference caused by the leakage Qu Wenruo
2020-05-20  6:58 ` [PATCH 2/2] btrfs: relocation: Clear the DEAD_RELOC_TREE bit for orphan roots to prevent runaway balance Qu Wenruo
2020-05-22 11:13 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200522111347.GJ18421@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-BTRFS Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \
		linux-btrfs@vger.kernel.org
	public-inbox-index linux-btrfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git