From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: David Sterba <dsterba@suse.cz>,
linux-btrfs@vger.kernel.org, Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH v2 1/3] btrfs: remove pointless out label in find_first_block_group
Date: Wed, 27 May 2020 15:06:27 +0200 [thread overview]
Message-ID: <20200527130627.GC18421@twin.jikos.cz> (raw)
In-Reply-To: <20200527081227.3408-2-johannes.thumshirn@wdc.com>
On Wed, May 27, 2020 at 05:12:25PM +0900, Johannes Thumshirn wrote:
> The 'out' label in find_first_block_group() does not do anything in terms
> of cleanup.
>
> It is better to directly return 'ret' instead of jumping to out to not
> confuse readers. Additionally there is no need to initialize ret with 0.
https://www.kernel.org/doc/html/latest/process/coding-style.html#centralized-exiting-of-functions
next prev parent reply other threads:[~2020-05-27 13:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:12 [PATCH v2 0/3] 3 small cleanups for find_first_block_group Johannes Thumshirn
2020-05-27 8:12 ` [PATCH v2 1/3] btrfs: remove pointless out label in find_first_block_group Johannes Thumshirn
2020-05-27 13:06 ` David Sterba [this message]
2020-05-27 13:45 ` Johannes Thumshirn
2020-06-01 15:34 ` David Sterba
2020-05-27 8:12 ` [PATCH v2 2/3] btrfs: get mapping tree directly from fsinfo " Johannes Thumshirn
2020-05-27 8:12 ` [PATCH v2 3/3] btrfs: factor out reading of bg from find_frist_block_group Johannes Thumshirn
2020-05-29 14:25 ` [PATCH v2 0/3] 3 small cleanups for find_first_block_group Johannes Thumshirn
2020-06-01 15:48 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200527130627.GC18421@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).