From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A227C433E0 for ; Wed, 27 May 2020 18:56:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03CED2073B for ; Wed, 27 May 2020 18:56:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728449AbgE0S4A (ORCPT ); Wed, 27 May 2020 14:56:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:55836 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725836AbgE0Sz7 (ORCPT ); Wed, 27 May 2020 14:55:59 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0E2FCAC5B; Wed, 27 May 2020 18:41:48 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 5A6D2DA72D; Wed, 27 May 2020 20:40:47 +0200 (CEST) Date: Wed, 27 May 2020 20:40:47 +0200 From: David Sterba To: Filipe Manana Cc: dsterba@suse.cz, linux-btrfs Subject: Re: [PATCH 1/3] Btrfs: fix wrong file range cleanup after an error filling dealloc range Message-ID: <20200527184046.GK18421@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Filipe Manana , linux-btrfs References: <20200527101553.25396-1-fdmanana@kernel.org> <20200527150159.GJ18421@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, May 27, 2020 at 05:31:48PM +0100, Filipe Manana wrote: > On Wed, May 27, 2020 at 4:02 PM David Sterba wrote: > > > > On Wed, May 27, 2020 at 11:15:53AM +0100, fdmanana@kernel.org wrote: > > > From: Filipe Manana > > > > > > If an error happens while running dellaloc in COW mode for a range, we can > > > end up calling extent_clear_unlock_delalloc() for a range that goes beyond > > > our range's end offset by 1 byte, which affects 1 extra page. This results > > > in clearing bits and doing page operations (such as a page unlock) outside > > > our target range. > > > > > > Fix that by calling extent_clear_unlock_delalloc() with an inclusive end > > > offset, instead of an exclusive end offset, at cow_file_range(). > > > > > > Fixes: a315e68f6e8b30 ("Btrfs: fix invalid attempt to free reserved space on failure to cow range") > > > Signed-off-by: Filipe Manana > > > > 1-3 added to misc-next, thanks. > > So I noticed earlier that in patch 3/3, I mention "generic/061" > instead of "btrfs/061". Would you mind amending the changelog with > just that? Changelog updated, thanks.