From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 0/6] btrfs-progs: btrfs-image related fixes
Date: Thu, 28 May 2020 20:05:04 +0200 [thread overview]
Message-ID: <20200528180504.GP18421@twin.jikos.cz> (raw)
In-Reply-To: <51ac5cc9-5902-663e-da51-b5a5004ec719@suse.com>
On Wed, May 27, 2020 at 06:46:53PM +0800, Qu Wenruo wrote:
> On 2020/5/27 下午6:28, Qu Wenruo wrote:
> > This branch can be fetched from github:
> > https://github.com/adam900710/btrfs-progs/tree/image_fixes
> >
> > Since there are two binary files updates, and one big code move, it's
> > recommended to fetch github repo, in case some patches didn't reach mail
> > list.
> >
> > This is inspried by one log tree replay dead loop bug, where the kind
> > reporter, Pierre Abbat <phma@bezitopo.org>, gave the btrfs-image to
> > reproduce it.
> >
> > Then the image fails to pass check due to the existing log tree
> > conflicting with device/chunk fixup.
> > As log tree blocks are not recorded in extent tree, later COW can use
> > log tree blocks and cause transid mismatch.
> >
> > To address the problem, this patchset will:
> > - Don't do any fixup if the source dump is single device
> > Since the dump has the full super block contents, we can easily check
> > if the source fs is single deivce.
> >
> > The chunk/device fixup is mostly for older btrfs-image behavior, which
> > always restores the fs into SINGLE profile.
> > However since commit 9088ab6a1067 ("btrfs-progs: make btrfs-image
> > restore to support dup"), btrfs-image can restore into DUP profile,
> > allowing us to do exact replay for single device fs.
> > This is patch 5.
>
> As expected, patch 3 can't survive the mail list filter.
> It's 402K, so I guess one needs to grab it from github anyway.
Thanks, patch picked from git and the whole patchset is now in devel.
prev parent reply other threads:[~2020-05-28 18:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 10:28 [PATCH 0/6] btrfs-progs: btrfs-image related fixes Qu Wenruo
2020-05-27 10:28 ` [PATCH 1/6] btrfs-progs: Allow btrfs_print_leaf() to be called on dummy eb whose fs_info is NULL Qu Wenruo
2020-05-27 10:28 ` [PATCH 2/6] btrfs-progs: print-tree: Export dump_superblock() Qu Wenruo
2020-05-27 10:28 ` [PATCH 4/6] btrfs-progs: fsck-tests: Update the image of test case 035 Qu Wenruo
2020-05-27 10:28 ` [PATCH 5/6] btrfs-progs: image: Don't modify the chunk and device tree if the source dump is single device Qu Wenruo
2020-05-27 10:28 ` [PATCH 6/6] btrfs-progs: image: Pin down log tree blocks before fixup Qu Wenruo
2020-05-27 10:46 ` [PATCH 0/6] btrfs-progs: btrfs-image related fixes Qu Wenruo
2020-05-28 18:05 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200528180504.GP18421@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).