From: Goldwyn Rodrigues <rgoldwyn@suse.de> To: linux-fsdevel@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Johannes.Thumshirn@wdc.com, hch@infradead.org, dsterba@suse.cz, darrick.wong@oracle.com, fdmanana@gmail.com Subject: [PATCH] iomap: Return zero in case of unsuccessful pagecache invalidation before DIO Date: Thu, 28 May 2020 14:21:03 -0500 Message-ID: <20200528192103.xm45qoxqmkw7i5yl@fiona> (raw) Filesystems such as btrfs are unable to guarantee page invalidation because pages could be locked as a part of the extent. Return zero in case a page cache invalidation is unsuccessful so filesystems can fallback to buffered I/O. This is similar to generic_file_direct_write(). This takes care of the following invalidation warning during btrfs mixed buffered and direct I/O using iomap_dio_rw(): Page cache invalidation failure on direct I/O. Possible data corruption due to collision with buffered I/O! Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com> diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c index e4addfc58107..215315be6233 100644 --- a/fs/iomap/direct-io.c +++ b/fs/iomap/direct-io.c @@ -483,9 +483,15 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, */ ret = invalidate_inode_pages2_range(mapping, pos >> PAGE_SHIFT, end >> PAGE_SHIFT); - if (ret) - dio_warn_stale_pagecache(iocb->ki_filp); - ret = 0; + /* + * If a page can not be invalidated, return 0 to fall back + * to buffered write. + */ + if (ret) { + if (ret == -EBUSY) + ret = 0; + goto out_free_dio; + } if (iov_iter_rw(iter) == WRITE && !wait_for_completion && !inode->i_sb->s_dio_done_wq) { -- Goldwyn
next reply index Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-28 19:21 Goldwyn Rodrigues [this message] 2020-05-29 0:23 ` Darrick J. Wong 2020-05-29 10:55 ` Filipe Manana 2020-05-29 11:31 ` Matthew Wilcox 2020-05-29 11:50 ` Filipe Manana 2020-05-29 12:45 ` Goldwyn Rodrigues 2020-06-01 15:16 ` Goldwyn Rodrigues 2020-06-03 11:23 ` Filipe Manana 2020-06-03 11:32 ` Filipe Manana 2020-06-03 19:02 ` Darrick J. Wong 2020-06-03 19:10 ` Filipe Manana 2020-06-03 19:18 ` Matthew Wilcox 2020-06-03 21:07 ` Goldwyn Rodrigues 2020-06-04 13:55 ` David Sterba
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200528192103.xm45qoxqmkw7i5yl@fiona \ --to=rgoldwyn@suse.de \ --cc=Johannes.Thumshirn@wdc.com \ --cc=darrick.wong@oracle.com \ --cc=dsterba@suse.cz \ --cc=fdmanana@gmail.com \ --cc=hch@infradead.org \ --cc=linux-btrfs@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-BTRFS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-btrfs/0 linux-btrfs/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-btrfs linux-btrfs/ https://lore.kernel.org/linux-btrfs \ linux-btrfs@vger.kernel.org public-inbox-index linux-btrfs Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-btrfs AGPL code for this site: git clone https://public-inbox.org/public-inbox.git