From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90676C433E0 for ; Wed, 1 Jul 2020 07:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7712D206C3 for ; Wed, 1 Jul 2020 07:50:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728411AbgGAHuJ (ORCPT ); Wed, 1 Jul 2020 03:50:09 -0400 Received: from verein.lst.de ([213.95.11.211]:39033 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728407AbgGAHuJ (ORCPT ); Wed, 1 Jul 2020 03:50:09 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C347F68B05; Wed, 1 Jul 2020 09:50:05 +0200 (CEST) Date: Wed, 1 Jul 2020 09:50:05 +0200 From: Christoph Hellwig To: Goldwyn Rodrigues Cc: linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org, fdmanana@gmail.com, dsterba@suse.cz, david@fromorbit.com, darrick.wong@oracle.com, hch@lst.de, Goldwyn Rodrigues Subject: Re: [PATCH 1/6] iomap: Convert wait_for_completion to flags Message-ID: <20200701075005.GA29884@lst.de> References: <20200629192353.20841-1-rgoldwyn@suse.de> <20200629192353.20841-2-rgoldwyn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200629192353.20841-2-rgoldwyn@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Mon, Jun 29, 2020 at 02:23:48PM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Convert wait_for_completion boolean to flags so we can pass more flags > to iomap_dio_rw() FYI, when I did this a while ago for a stalled patch series I used a single namespace for the flags passed to iomap_dio_rw and the flags store in dio->flag, which at that point seemed a bit cleaner to me: http://git.infradead.org/users/hch/xfs.git/commitdiff/1733619fefab1b0020d3ab91ebd0a72ccec982af