From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED3FEC433E6 for ; Mon, 31 Aug 2020 12:25:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1E7D206CD for ; Mon, 31 Aug 2020 12:25:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726791AbgHaMZ5 (ORCPT ); Mon, 31 Aug 2020 08:25:57 -0400 Received: from mx2.suse.de ([195.135.220.15]:35432 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbgHaMZ4 (ORCPT ); Mon, 31 Aug 2020 08:25:56 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 11E4BB7CD; Mon, 31 Aug 2020 12:25:55 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 4EBC0DA840; Mon, 31 Aug 2020 14:24:44 +0200 (CEST) Date: Mon, 31 Aug 2020 14:24:44 +0200 From: David Sterba To: Anand Jain Cc: Nikolay Borisov , linux-btrfs@vger.kernel.org Subject: Re: [PATCH 1/5] btrfs: Factor out reada loop in __reada_start_machine Message-ID: <20200831122444.GV28318@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Anand Jain , Nikolay Borisov , linux-btrfs@vger.kernel.org References: <20200715104850.19071-1-nborisov@suse.com> <20200715104850.19071-2-nborisov@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sat, Aug 29, 2020 at 11:06:32PM +0800, Anand Jain wrote: > On 15/7/20 6:48 pm, Nikolay Borisov wrote: > > This is in preparation for moving fs_devices to proper lists. > > > > Signed-off-by: Nikolay Borisov > > --- > > fs/btrfs/reada.c | 21 ++++++++++++++++----- > > 1 file changed, 16 insertions(+), 5 deletions(-) > > > > diff --git a/fs/btrfs/reada.c b/fs/btrfs/reada.c > > index 243a2e44526e..aa9d24ed56d7 100644 > > --- a/fs/btrfs/reada.c > > +++ b/fs/btrfs/reada.c > > @@ -767,15 +767,14 @@ static void reada_start_machine_worker(struct btrfs_work *work) > > kfree(rmw); > > } > > > > -static void __reada_start_machine(struct btrfs_fs_info *fs_info) > > + > > +/* Try to start up to 10k READA requests for a group of devices. */ > > +static int __reada_start_for_fsdevs(struct btrfs_fs_devices *fs_devices) > > In my experience David doesn't prefer __ prefix for helper functions. Right, I've updated the patch to drop the __ as there's no other function without the underscores (unlike __reada_start_machine/reada_start_machine)