From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: Re: [PATCH 0/4][v2] Lockdep fixes
Date: Fri, 4 Sep 2020 16:20:00 +0200 [thread overview]
Message-ID: <20200904142000.GX28318@twin.jikos.cz> (raw)
In-Reply-To: <cover.1598996236.git.josef@toxicpanda.com>
On Tue, Sep 01, 2020 at 05:40:34PM -0400, Josef Bacik wrote:
> v1->v2:
> - Included the add_missing_dev patch in the series.
> - Added a patch to kill the rcu protection for fs_info->space_info.
> - Fixed the raid sysfs init stuff to be completely out of link_block_group, as
> it causes a lockdep splat with the rwsem conversion.
>
> Hello,
>
> These are the last two lockdep splats I'm able to see in my testing. We have
> like 4 variations of the same lockdep splat that's addressed by
>
> btrfs: do not create raid sysfs entries under chunk_mutex
>
> Basically this particular dependency pulls in the kernfs_mutex under the
> chunk_mutex, and so we have like 4 issues in github with slightly different
> splats, but are all fixed by that fix. With these two patches (and the one I
> sent the other day for add_missing_dev) I haven't hit any lockdep splats in 6
> runs of xfstests on 3 different VMs in the last 12 hours. That means it should
> take Dave at least 2 runs before he hits a new one. Thanks,
>
> Josef Bacik (4):
> btrfs: fix lockdep splat in add_missing_dev
> btrfs: init sysfs for devices outside of the chunk_mutex
So the two patches were in misc-next and I started to see lockdep
complaining in btrfs/011, which is very early in the test list and this
makes it impossible to notice further lockdep reports.
I'll move the patches to a topic branch and will retest misc-next to see
what's the actual list of lockdep things to fix, so we have a clean
state before the eb rwsem switch.
next prev parent reply other threads:[~2020-09-04 14:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 21:40 [PATCH 0/4][v2] Lockdep fixes Josef Bacik
2020-09-01 21:40 ` [PATCH 1/4] btrfs: fix lockdep splat in add_missing_dev Josef Bacik
2020-09-02 6:23 ` Anand Jain
2020-09-03 11:17 ` David Sterba
2020-09-01 21:40 ` [PATCH 2/4] btrfs: init sysfs for devices outside of the chunk_mutex Josef Bacik
2020-09-02 6:21 ` Anand Jain
2020-09-02 17:45 ` David Sterba
2020-09-03 11:41 ` Anand Jain
2020-09-03 11:42 ` Anand Jain
2020-09-03 11:18 ` David Sterba
2020-09-01 21:40 ` [PATCH 3/4] btrfs: kill the rcu protection for fs_info->space_info Josef Bacik
2020-09-02 8:04 ` Nikolay Borisov
2020-09-02 10:32 ` David Sterba
2020-09-01 21:40 ` [PATCH 4/4] btrfs: do not create raid sysfs entries under any locks Josef Bacik
2020-09-08 12:40 ` David Sterba
2020-09-08 12:52 ` Josef Bacik
2020-09-04 14:20 ` David Sterba [this message]
2020-09-07 13:05 ` [PATCH 0/4][v2] Lockdep fixes David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200904142000.GX28318@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).