From: David Sterba <dsterba@suse.cz>
To: Anand Jain <anand.jain@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs: improve messages when devices rescanned
Date: Mon, 7 Sep 2020 21:39:16 +0200 [thread overview]
Message-ID: <20200907193916.GD28318@twin.jikos.cz> (raw)
In-Reply-To: <674264e45246039a7d294415b2e0f42434ec8070.1599139776.git.anand.jain@oracle.com>
On Thu, Sep 03, 2020 at 09:30:12PM +0800, Anand Jain wrote:
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> + "duplicate device %s devid %llu generation %llu scanned by %s (%d)",
> + "devid %llu device path %s changed to %s scanned by %s (pid %d)",
I haven't found a wording that would make the messages follow the same
pattern, eg. that both describe the change and then print the details.
The path change should keep the devid first and the old/new paths
together. So let it be the way it was sent, with the 'pid' removed.
Added to misc-next, thanks.
prev parent reply other threads:[~2020-09-07 19:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 7:27 [PATCH] btrfs: improve messages when devices rescanned Anand Jain
2020-09-03 8:16 ` Nikolay Borisov
2020-09-03 9:41 ` Anand Jain
2020-09-03 9:42 ` Nikolay Borisov
2020-09-03 10:10 ` David Sterba
2020-09-03 13:30 ` [PATCH v2] " Anand Jain
2020-09-07 19:39 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200907193916.GD28318@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).