From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F146C5517A for ; Tue, 10 Nov 2020 02:09:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 222D220679 for ; Tue, 10 Nov 2020 02:09:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="vXSUE0pe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729906AbgKJCJQ (ORCPT ); Mon, 9 Nov 2020 21:09:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:59852 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727311AbgKJCJQ (ORCPT ); Mon, 9 Nov 2020 21:09:16 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1604974155; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=3O9/D8xFJSUfMAOoxjDsugdC30Pxu7e32VLvA99cac4=; b=vXSUE0pedFzc5u8uS91ZNMlmfKAE3qjyiBr4P+bOH73N72c2k9z/pvxpFDICBmXCnWgAJd KsJKWXI/B/mGaI1mLr2wTSP7uFUOEBtwMTxm5LXQYd3nnjKpMw2YPiBEsQC7++ABrQfCFg c5xYcT5zyRI+G3whs/PCbzMJ5GXrT5c= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 034A5AC24 for ; Tue, 10 Nov 2020 02:09:15 +0000 (UTC) From: Qu Wenruo To: linux-btrfs@vger.kernel.org Subject: [PATCH v2 0/2] btrfs: paramater refactors for data and metadata endio call backs Date: Tue, 10 Nov 2020 10:09:07 +0800 Message-Id: <20201110020909.23438-1-wqu@suse.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org This is another cleanup exposed when I'm fixing my subpage patchset. Dating back to the old time where we still have hooks for data/metadata endio, we have a parameter called @phy_offset for both hooks. That @phy_offset is the number of sectors compared to the bio on-disk bytenr, and is used to grab the csum from btrfs_io_bio. This is far from straightforward, and costs reader tons of time to grasp the basic. This patchset will change it by: - Remove phy_offset completely for metadata Since metadata doesn't use btrfs_io_bio::csums[] at all, there is no need for it. - Use @disk_bytenr to replace @phy_offset/@icsum Let the callee, check_data_csum() to calculate the offset from @disk_bytenr and bio to get the csum offset. Changelog: v2: - Update commit message to remove the wrong comment on btrfs_io_bio->logical That logical is mess, it has different meanings for different use cases. What we should refer to is bio->bi_iter.bi_sector. - Remove the false-alert prone ASSERT() Even at endio time. bio->bi_iter.bi_size can change due to incoming finished IOs. This means we can't really rely on bio->bi_iter.bi_size to check if our disk_bytenr is still valid. Qu Wenruo (2): btrfs: remove the phy_offset parameter for btrfs_validate_metadata_buffer() btrfs: pass disk_bytenr directly for check_data_csum() fs/btrfs/disk-io.c | 2 +- fs/btrfs/disk-io.h | 2 +- fs/btrfs/extent_io.c | 16 +++++++++------- fs/btrfs/inode.c | 26 +++++++++++++++++--------- 4 files changed, 28 insertions(+), 18 deletions(-) -- 2.29.2