From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01996C3E8C5 for ; Fri, 27 Nov 2020 18:50:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD99D21D7F for ; Fri, 27 Nov 2020 18:50:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729486AbgK0Stm (ORCPT ); Fri, 27 Nov 2020 13:49:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:58044 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729225AbgK0Ssh (ORCPT ); Fri, 27 Nov 2020 13:48:37 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id F36B2AC0C; Fri, 27 Nov 2020 18:48:50 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id EC17ADA7D9; Fri, 27 Nov 2020 19:47:20 +0100 (CET) Date: Fri, 27 Nov 2020 19:47:20 +0100 From: David Sterba To: Anand Jain Cc: Naohiro Aota , linux-btrfs@vger.kernel.org, dsterba@suse.com, hare@suse.com, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , "Darrick J. Wong" , Josef Bacik Subject: Re: [PATCH v10 06/41] btrfs: introduce max_zone_append_size Message-ID: <20201127184720.GC6430@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Anand Jain , Naohiro Aota , linux-btrfs@vger.kernel.org, dsterba@suse.com, hare@suse.com, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , "Darrick J. Wong" , Josef Bacik References: <173cd5def63acdf094a3b83ce129696c26fd3a3c.1605007036.git.naohiro.aota@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Nov 19, 2020 at 05:23:20PM +0800, Anand Jain wrote: > On 10/11/20 7:26 pm, Naohiro Aota wrote: > > The zone append write command has a maximum IO size restriction it > > accepts. This is because a zone append write command cannot be split, as > > we ask the device to place the data into a specific target zone and the > > device responds with the actual written location of the data. > > > > Introduce max_zone_append_size to zone_info and fs_info to track the > > value, so we can limit all I/O to a zoned block device that we want to > > write using the zone append command to the device's limits. > > > > Reviewed-by: Josef Bacik > > Signed-off-by: Naohiro Aota > > --- > > Looks good except for - what happens when we replace or add a new zone > device with a different queue_max_zone_append_sectors(queue) value. ? The max zone seems to be a constraint for all devices so yeah it should be recalculated.