From: David Sterba <dsterba@suse.cz>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: syzbot <syzbot+6700bca07dff187809c4@syzkaller.appspotmail.com>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-btrfs@vger.kernel.org
Subject: Re: KASAN: null-ptr-deref Write in start_transaction
Date: Fri, 8 Jan 2021 15:05:30 +0100 [thread overview]
Message-ID: <20210108140529.GX6430@twin.jikos.cz> (raw)
In-Reply-To: <CACT4Y+YJCMyTDrUFWXEnZ-raQMos0+1F1O8k5eX998pqNUWKSw@mail.gmail.com>
On Fri, Jan 08, 2021 at 10:17:25AM +0100, Dmitry Vyukov wrote:
> On Thu, Jan 7, 2021 at 2:11 PM syzbot
> <syzbot+6700bca07dff187809c4@syzkaller.appspotmail.com> wrote:
> >
> > syzbot suspects this issue was fixed by commit:
> >
> > commit f30bed83426c5cb9fce6cabb3f7cc5a9d5428fcc
> > Author: Filipe Manana <fdmanana@suse.com>
> > Date: Fri Nov 13 11:24:17 2020 +0000
> >
> > btrfs: remove unnecessary attempt to drop extent maps after adding inline extent
> >
> > bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=13ddc30b500000
> > start commit: 521b619a Merge tag 'linux-kselftest-kunit-fixes-5.10-rc3' ..
> > git tree: upstream
> > kernel config: https://syzkaller.appspot.com/x/.config?x=61033507391c77ff
> > dashboard link: https://syzkaller.appspot.com/bug?extid=6700bca07dff187809c4
> > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14a07ab2500000
> > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=10fe69c6500000
> >
> > If the result looks correct, please mark the issue as fixed by replying with:
> >
> > #syz fix: btrfs: remove unnecessary attempt to drop extent maps after adding inline extent
> >
> > For information about bisection process see: https://goo.gl/tpsmEJ#bisection
>
> #syz fix: btrfs: remove unnecessary attempt to drop extent maps after
> adding inline extent
I have looked at the report and suspected fix yestereday and was not
sure that it's really the right fix. The commit removes some call so it
all looks like an accidental fix and something still might be going on.
So I'm a bit surprised that you mark it as fixed. It will make the
syzbot report go away so from that POV ok and we'll know if it happens
again, but I'd expect at least some analysis before closing the report.
next prev parent reply other threads:[~2021-01-08 14:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 18:55 KASAN: null-ptr-deref Write in start_transaction syzbot
2021-01-07 13:11 ` syzbot
2021-01-08 9:17 ` Dmitry Vyukov
2021-01-08 14:05 ` David Sterba [this message]
2021-01-08 14:22 ` Filipe Manana
2021-01-08 14:33 ` David Sterba
2021-01-08 14:35 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108140529.GX6430@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dvyukov@google.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+6700bca07dff187809c4@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).