From: kernel test robot <lkp@intel.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Cc: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 20/22] btrfs: introduce btrfs_subpage for data inodes
Date: Sat, 9 Jan 2021 17:53:17 +0800 [thread overview]
Message-ID: <202101091743.2pQvfWL3-lkp@intel.com> (raw)
In-Reply-To: <20210106010201.37864-21-wqu@suse.com>
[-- Attachment #1: Type: text/plain, Size: 7480 bytes --]
Hi Qu,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on kdave/for-next]
[also build test WARNING on v5.11-rc2 next-20210108]
[cannot apply to btrfs/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Qu-Wenruo/btrfs-add-read-only-support-for-subpage-sector-size/20210106-090847
base: https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-next
config: i386-randconfig-m021-20210108 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
smatch warnings:
fs/btrfs/inode.c:8353 btrfs_page_mkwrite() warn: unsigned 'ret' is never less than zero.
vim +/ret +8353 fs/btrfs/inode.c
8275
8276 /*
8277 * btrfs_page_mkwrite() is not allowed to change the file size as it gets
8278 * called from a page fault handler when a page is first dirtied. Hence we must
8279 * be careful to check for EOF conditions here. We set the page up correctly
8280 * for a written page which means we get ENOSPC checking when writing into
8281 * holes and correct delalloc and unwritten extent mapping on filesystems that
8282 * support these features.
8283 *
8284 * We are not allowed to take the i_mutex here so we have to play games to
8285 * protect against truncate races as the page could now be beyond EOF. Because
8286 * truncate_setsize() writes the inode size before removing pages, once we have
8287 * the page lock we can determine safely if the page is beyond EOF. If it is not
8288 * beyond EOF, then the page is guaranteed safe against truncation until we
8289 * unlock the page.
8290 */
8291 vm_fault_t btrfs_page_mkwrite(struct vm_fault *vmf)
8292 {
8293 struct page *page = vmf->page;
8294 struct inode *inode = file_inode(vmf->vma->vm_file);
8295 struct btrfs_fs_info *fs_info = btrfs_sb(inode->i_sb);
8296 struct extent_io_tree *io_tree = &BTRFS_I(inode)->io_tree;
8297 struct btrfs_ordered_extent *ordered;
8298 struct extent_state *cached_state = NULL;
8299 struct extent_changeset *data_reserved = NULL;
8300 char *kaddr;
8301 unsigned long zero_start;
8302 loff_t size;
8303 vm_fault_t ret;
8304 int ret2;
8305 int reserved = 0;
8306 u64 reserved_space;
8307 u64 page_start;
8308 u64 page_end;
8309 u64 end;
8310
8311 reserved_space = PAGE_SIZE;
8312
8313 sb_start_pagefault(inode->i_sb);
8314 page_start = page_offset(page);
8315 page_end = page_start + PAGE_SIZE - 1;
8316 end = page_end;
8317
8318 /*
8319 * Reserving delalloc space after obtaining the page lock can lead to
8320 * deadlock. For example, if a dirty page is locked by this function
8321 * and the call to btrfs_delalloc_reserve_space() ends up triggering
8322 * dirty page write out, then the btrfs_writepage() function could
8323 * end up waiting indefinitely to get a lock on the page currently
8324 * being processed by btrfs_page_mkwrite() function.
8325 */
8326 ret2 = btrfs_delalloc_reserve_space(BTRFS_I(inode), &data_reserved,
8327 page_start, reserved_space);
8328 if (!ret2) {
8329 ret2 = file_update_time(vmf->vma->vm_file);
8330 reserved = 1;
8331 }
8332 if (ret2) {
8333 ret = vmf_error(ret2);
8334 if (reserved)
8335 goto out;
8336 goto out_noreserve;
8337 }
8338
8339 ret = VM_FAULT_NOPAGE; /* make the VM retry the fault */
8340 again:
8341 lock_page(page);
8342 size = i_size_read(inode);
8343
8344 if ((page->mapping != inode->i_mapping) ||
8345 (page_start >= size)) {
8346 /* page got truncated out from underneath us */
8347 goto out_unlock;
8348 }
8349 wait_on_page_writeback(page);
8350
8351 lock_extent_bits(io_tree, page_start, page_end, &cached_state);
8352 ret = set_page_extent_mapped(page);
> 8353 if (ret < 0)
8354 goto out_unlock;
8355
8356 /*
8357 * we can't set the delalloc bits if there are pending ordered
8358 * extents. Drop our locks and wait for them to finish
8359 */
8360 ordered = btrfs_lookup_ordered_range(BTRFS_I(inode), page_start,
8361 PAGE_SIZE);
8362 if (ordered) {
8363 unlock_extent_cached(io_tree, page_start, page_end,
8364 &cached_state);
8365 unlock_page(page);
8366 btrfs_start_ordered_extent(ordered, 1);
8367 btrfs_put_ordered_extent(ordered);
8368 goto again;
8369 }
8370
8371 if (page->index == ((size - 1) >> PAGE_SHIFT)) {
8372 reserved_space = round_up(size - page_start,
8373 fs_info->sectorsize);
8374 if (reserved_space < PAGE_SIZE) {
8375 end = page_start + reserved_space - 1;
8376 btrfs_delalloc_release_space(BTRFS_I(inode),
8377 data_reserved, page_start,
8378 PAGE_SIZE - reserved_space, true);
8379 }
8380 }
8381
8382 /*
8383 * page_mkwrite gets called when the page is firstly dirtied after it's
8384 * faulted in, but write(2) could also dirty a page and set delalloc
8385 * bits, thus in this case for space account reason, we still need to
8386 * clear any delalloc bits within this page range since we have to
8387 * reserve data&meta space before lock_page() (see above comments).
8388 */
8389 clear_extent_bit(&BTRFS_I(inode)->io_tree, page_start, end,
8390 EXTENT_DELALLOC | EXTENT_DO_ACCOUNTING |
8391 EXTENT_DEFRAG, 0, 0, &cached_state);
8392
8393 ret2 = btrfs_set_extent_delalloc(BTRFS_I(inode), page_start, end, 0,
8394 &cached_state);
8395 if (ret2) {
8396 unlock_extent_cached(io_tree, page_start, page_end,
8397 &cached_state);
8398 ret = VM_FAULT_SIGBUS;
8399 goto out_unlock;
8400 }
8401
8402 /* page is wholly or partially inside EOF */
8403 if (page_start + PAGE_SIZE > size)
8404 zero_start = offset_in_page(size);
8405 else
8406 zero_start = PAGE_SIZE;
8407
8408 if (zero_start != PAGE_SIZE) {
8409 kaddr = kmap(page);
8410 memset(kaddr + zero_start, 0, PAGE_SIZE - zero_start);
8411 flush_dcache_page(page);
8412 kunmap(page);
8413 }
8414 ClearPageChecked(page);
8415 set_page_dirty(page);
8416 SetPageUptodate(page);
8417
8418 BTRFS_I(inode)->last_trans = fs_info->generation;
8419 BTRFS_I(inode)->last_sub_trans = BTRFS_I(inode)->root->log_transid;
8420 BTRFS_I(inode)->last_log_commit = BTRFS_I(inode)->root->last_log_commit;
8421
8422 unlock_extent_cached(io_tree, page_start, page_end, &cached_state);
8423
8424 btrfs_delalloc_release_extents(BTRFS_I(inode), PAGE_SIZE);
8425 sb_end_pagefault(inode->i_sb);
8426 extent_changeset_free(data_reserved);
8427 return VM_FAULT_LOCKED;
8428
8429 out_unlock:
8430 unlock_page(page);
8431 out:
8432 btrfs_delalloc_release_extents(BTRFS_I(inode), PAGE_SIZE);
8433 btrfs_delalloc_release_space(BTRFS_I(inode), data_reserved, page_start,
8434 reserved_space, (ret != 0));
8435 out_noreserve:
8436 sb_end_pagefault(inode->i_sb);
8437 extent_changeset_free(data_reserved);
8438 return ret;
8439 }
8440
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29921 bytes --]
next prev parent reply other threads:[~2021-01-09 9:54 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 1:01 [PATCH v3 00/22] btrfs: add read-only support for subpage sector size Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 01/22] btrfs: extent_io: rename @offset parameter to @disk_bytenr for submit_extent_page() Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 02/22] btrfs: extent_io: refactor __extent_writepage_io() to improve readability Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 03/22] btrfs: file: update comment for btrfs_dirty_pages() Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 04/22] btrfs: extent_io: update locked page dirty/writeback/error bits in __process_pages_contig() Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 05/22] btrfs: extent_io: merge PAGE_CLEAR_DIRTY and PAGE_SET_WRITEBACK into PAGE_START_WRITEBACK Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 06/22] btrfs: extent_io: introduce a helper to grab an existing extent buffer from a page Qu Wenruo
2021-01-12 15:08 ` David Sterba
2021-01-06 1:01 ` [PATCH v3 07/22] btrfs: extent_io: introduce the skeleton of btrfs_subpage structure Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 08/22] btrfs: extent_io: make attach_extent_buffer_page() to handle subpage case Qu Wenruo
2021-01-06 6:54 ` Qu Wenruo
2021-01-07 1:35 ` Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 09/22] btrfs: extent_io: make grab_extent_buffer_from_page() " Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 10/22] btrfs: extent_io: support subpage for extent buffer page release Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 11/22] btrfs: extent_io: attach private to dummy extent buffer pages Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 12/22] btrfs: subpage: introduce helper for subpage uptodate status Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 13/22] btrfs: subpage: introduce helper for subpage error status Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 14/22] btrfs: extent_io: make set/clear_extent_buffer_uptodate() to support subpage size Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 15/22] btrfs: extent_io: make btrfs_clone_extent_buffer() to be subpage compatible Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 16/22] btrfs: extent_io: implement try_release_extent_buffer() for subpage metadata support Qu Wenruo
2021-01-06 8:24 ` Qu Wenruo
2021-01-06 8:43 ` Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 17/22] btrfs: extent_io: introduce read_extent_buffer_subpage() Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 18/22] btrfs: extent_io: make endio_readpage_update_page_status() to handle subpage case Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 19/22] btrfs: disk-io: introduce subpage metadata validation check Qu Wenruo
2021-01-06 1:01 ` [PATCH v3 20/22] btrfs: introduce btrfs_subpage for data inodes Qu Wenruo
2021-01-06 5:04 ` kernel test robot
2021-01-06 5:32 ` Qu Wenruo
2021-01-06 6:48 ` Rong Chen
2021-01-09 9:53 ` kernel test robot [this message]
2021-01-06 1:02 ` [PATCH v3 21/22] btrfs: integrate page status update for read path into begin/end_page_read() Qu Wenruo
2021-01-06 1:02 ` [PATCH v3 22/22] btrfs: allow RO mount of 4K sector size fs on 64K page system Qu Wenruo
2021-01-12 15:14 ` [PATCH v3 00/22] btrfs: add read-only support for subpage sector size David Sterba
2021-01-13 5:06 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202101091743.2pQvfWL3-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).