From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6ACAC433DB for ; Sun, 24 Jan 2021 11:52:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C28C23100 for ; Sun, 24 Jan 2021 11:52:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726837AbhAXLww (ORCPT ); Sun, 24 Jan 2021 06:52:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:40218 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726900AbhAXLwM (ORCPT ); Sun, 24 Jan 2021 06:52:12 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 18424AD3E; Sun, 24 Jan 2021 11:51:30 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 3DF8EDA7D7; Sun, 24 Jan 2021 12:49:44 +0100 (CET) Date: Sun, 24 Jan 2021 12:49:44 +0100 From: David Sterba To: Qu Wenruo Cc: dsterba@suse.cz, Qu Wenruo , Josef Bacik , linux-btrfs@vger.kernel.org Subject: Re: [PATCH v4 01/18] btrfs: update locked page dirty/writeback/error bits in __process_pages_contig() Message-ID: <20210124114944.GE1993@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , Qu Wenruo , Josef Bacik , linux-btrfs@vger.kernel.org References: <20210116071533.105780-1-wqu@suse.com> <20210116071533.105780-2-wqu@suse.com> <20210123191304.GA1993@twin.jikos.cz> <838b4acf-16fa-eaf8-e151-fc8b734c9b49@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <838b4acf-16fa-eaf8-e151-fc8b734c9b49@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Sun, Jan 24, 2021 at 08:35:27AM +0800, Qu Wenruo wrote: > On 2021/1/24 上午3:13, David Sterba wrote: > > On Thu, Jan 21, 2021 at 02:51:46PM +0800, Qu Wenruo wrote: > >> On 2021/1/21 下午2:32, Qu Wenruo wrote: > >>> On 2021/1/20 上午5:41, Josef Bacik wrote: > >>>> On 1/16/21 2:15 AM, Qu Wenruo wrote: > >> To be more clear, we call extent_clear_unlock_delalloc() with > >> locked_page == NULL, to allow __process_pages_contig() to unlock the > >> locked page (while the locked page isn't locked by > >> __process_pages_contig()). > >> > >> For subpage data, we need writers accounting for subpage, but that > >> accounting only happens in __process_pages_contig(), thus we don't want > >> pages without the accounting to be unlocked by __process_pages_contig(). > >> > >> I can do extra page unlock/clear_dirty/end_writeback just for that > >> exception, but it would definitely needs more comments. > > > > This is patch 1 and other depend on the changed behaviour so if it's > > just updated changelog and comments, and Josef is ok with the result, I > > can take it but otherwise this could delay the series once the rest is > > reworked. > > > In fact there aren't many changes depending on it, until we hit RW support. > > Thus I can move this patch to RW series, so that we can fully focus on > RO support. That's a good option. > The patchset will be delayed for a while (ETA in week 04), mostly due to > the change in how we handle metadata ref count (other than just > under_alloc). > > Would this be OK for you? Yes that OK, thanks.