From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F32E6C433DB for ; Tue, 26 Jan 2021 23:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C12BC20663 for ; Tue, 26 Jan 2021 23:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731721AbhAZXFE (ORCPT ); Tue, 26 Jan 2021 18:05:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:32980 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730103AbhAZRFB (ORCPT ); Tue, 26 Jan 2021 12:05:01 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B1F8CB761; Tue, 26 Jan 2021 16:43:42 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 9DC60DA7D2; Tue, 26 Jan 2021 17:41:53 +0100 (CET) Date: Tue, 26 Jan 2021 17:41:53 +0100 From: David Sterba To: Josef Bacik Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 0/5] Serious fixes for different error paths Message-ID: <20210126164153.GQ1993@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Josef Bacik , linux-btrfs@vger.kernel.org, kernel-team@fb.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Thu, Jan 14, 2021 at 02:02:41PM -0500, Josef Bacik wrote: > v1->v2: > - Rebased onto misc-next, dropping everything that's been merged so far. > - Fixed "btrfs: splice remaining dirty_bg's onto the transaction dirty bg list" > to handle the btrfs_alloc_path() failure and cleaned up the error handling as > a result of that change. > - dropped "btrfs: don't clear ret in btrfs_start_dirty_block_groups" as I fixed > it differently in "btrfs: splice remaining dirty_bg's onto the transaction > dirty bg list" > - Added a link to Zygo's original report in "btrfs: add asserts for deleting > backref cache nodes". > - Clarified the error condition that lead to the WARN_ON() in the changelog for > "btrfs: do not WARN_ON() if we can't find the reloc root". > - Added the stack trace that the error injection triggered in order to get the > error that happened in "btrfs: abort the transaction if we fail to inc ref in > btrfs_copy_root". Added to misc-next, thanks.