From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65074C433E6 for ; Wed, 27 Jan 2021 13:51:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 268382074D for ; Wed, 27 Jan 2021 13:51:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232274AbhA0Nvb (ORCPT ); Wed, 27 Jan 2021 08:51:31 -0500 Received: from mx2.suse.de ([195.135.220.15]:34192 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231415AbhA0Nuf (ORCPT ); Wed, 27 Jan 2021 08:50:35 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 44975AD8C; Wed, 27 Jan 2021 13:49:46 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 03F98DA84C; Wed, 27 Jan 2021 14:47:58 +0100 (CET) Date: Wed, 27 Jan 2021 14:47:58 +0100 From: David Sterba To: Qu Wenruo Cc: dsterba@suse.cz, matthias.bgg@kernel.org, Marek Behun , u-boot@lists.denx.de, linux-btrfs@vger.kernel.org, Matthias Brugger Subject: Re: [PATCH] fs: btrfs: Select SHA256 in Kconfig Message-ID: <20210127134758.GA1993@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Qu Wenruo , matthias.bgg@kernel.org, Marek Behun , u-boot@lists.denx.de, linux-btrfs@vger.kernel.org, Matthias Brugger References: <20210127094231.11740-1-matthias.bgg@kernel.org> <20210127120146.GZ1993@twin.jikos.cz> <5ae76d50-a52d-6f0e-1f23-335cb32f0371@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5ae76d50-a52d-6f0e-1f23-335cb32f0371@suse.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Wed, Jan 27, 2021 at 08:14:31PM +0800, Qu Wenruo wrote: > > > On 2021/1/27 下午8:01, David Sterba wrote: > > On Wed, Jan 27, 2021 at 10:42:30AM +0100, matthias.bgg@kernel.org wrote: > >> From: Matthias Brugger > >> > >> Since commit 565a4147d17a ("fs: btrfs: Add more checksum algorithms") > >> btrfs uses the sha256 checksum algorithm. But Kconfig lacks to select > >> it. This leads to compilation errors: > >> fs/built-in.o: In function `hash_sha256': > >> fs/btrfs/crypto/hash.c:25: undefined reference to `sha256_starts' > >> fs/btrfs/crypto/hash.c:26: undefined reference to `sha256_update' > >> fs/btrfs/crypto/hash.c:27: undefined reference to `sha256_finish' > >> > >> Signed-off-by: Matthias Brugger > > > > So this is a fix for u-boot, got me confused and not for the first time > > as there's Kconfig and the same fs/btrfs/ directory structure. > > > Well, sometimes too unified file structure/code base can also be a problem. > > Considering I'm also going to continue cross-porting more code to > U-boot, any recommendation on this? > Using different prefix? If it's a series then please mention u-boot in the cover letter, no need to change the patches, I'll go check CC if I'm too confused about the patch.