From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Josef Bacik <josef@toxicpanda.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v5 00/18] btrfs: add read-only support for subpage sector size
Date: Thu, 28 Jan 2021 11:34:52 +0100 [thread overview]
Message-ID: <20210128103452.GG1993@twin.jikos.cz> (raw)
In-Reply-To: <e370c8d6-8559-c8a0-9938-160e003e933b@gmx.com>
On Thu, Jan 28, 2021 at 08:30:21AM +0800, Qu Wenruo wrote:
> >> btrfs: support subpage for extent buffer page release
> >
> > I don't have this patch in my inbox so I can't reply to it directly, but
> > you include refcount.h, but then use normal atomics. Please used the
> > actual refcount_t, as it gets us all the debugging stuff that makes
> > finding problems much easier. Thanks,
>
> My bad, my initial plan is to use refcount, but the use case has valid 0
> refcount usage, thus refcount is not good here.
In case you need to shift the "0" you can use refcount_dec_not_one or
refcount_inc/dec_not_zero, but I haven't seen the code so don't know if
this applies in your case.
next prev parent reply other threads:[~2021-01-28 10:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 8:33 [PATCH v5 00/18] btrfs: add read-only support for subpage sector size Qu Wenruo
2021-01-26 8:33 ` [PATCH v5 01/18] btrfs: merge PAGE_CLEAR_DIRTY and PAGE_SET_WRITEBACK to PAGE_START_WRITEBACK Qu Wenruo
2021-01-27 15:56 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 02/18] btrfs: set UNMAPPED bit early in btrfs_clone_extent_buffer() for subpage support Qu Wenruo
2021-01-27 15:56 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 03/18] btrfs: introduce the skeleton of btrfs_subpage structure Qu Wenruo
2021-01-26 8:33 ` [PATCH v5 04/18] btrfs: make attach_extent_buffer_page() handle subpage case Qu Wenruo
2021-01-27 16:01 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 05/18] btrfs: make grab_extent_buffer_from_page() " Qu Wenruo
2021-01-27 16:20 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 06/18] btrfs: support subpage for extent buffer page release Qu Wenruo
2021-01-27 16:21 ` Josef Bacik
2021-02-01 15:32 ` David Sterba
2021-01-26 8:33 ` [PATCH v5 07/18] btrfs: attach private to dummy extent buffer pages Qu Wenruo
2021-01-27 16:21 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 08/18] btrfs: introduce helpers for subpage uptodate status Qu Wenruo
2021-01-27 16:34 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 09/18] btrfs: introduce helpers for subpage error status Qu Wenruo
2021-01-27 16:34 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 10/18] btrfs: support subpage in set/clear_extent_buffer_uptodate() Qu Wenruo
2021-01-27 16:35 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 11/18] btrfs: support subpage in btrfs_clone_extent_buffer Qu Wenruo
2021-01-27 16:35 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 12/18] btrfs: support subpage in try_release_extent_buffer() Qu Wenruo
2021-01-27 16:37 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 13/18] btrfs: introduce read_extent_buffer_subpage() Qu Wenruo
2021-01-27 16:39 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 14/18] btrfs: support subpage in endio_readpage_update_page_status() Qu Wenruo
2021-01-27 16:42 ` Josef Bacik
2021-01-26 8:33 ` [PATCH v5 15/18] btrfs: introduce subpage metadata validation check Qu Wenruo
2021-01-27 16:47 ` Josef Bacik
2021-01-26 8:34 ` [PATCH v5 16/18] btrfs: introduce btrfs_subpage for data inodes Qu Wenruo
2021-01-27 16:56 ` Josef Bacik
2021-02-01 15:42 ` David Sterba
2021-01-26 8:34 ` [PATCH v5 17/18] btrfs: integrate page status update for data read path into begin/end_page_read() Qu Wenruo
2021-01-27 17:13 ` Josef Bacik
2021-02-01 15:47 ` David Sterba
2021-01-26 8:34 ` [PATCH v5 18/18] btrfs: allow RO mount of 4K sector size fs on 64K page system Qu Wenruo
2021-01-27 17:13 ` Josef Bacik
2021-02-01 15:49 ` David Sterba
2021-01-27 16:17 ` [PATCH v5 00/18] btrfs: add read-only support for subpage sector size Josef Bacik
2021-01-28 0:30 ` Qu Wenruo
2021-01-28 10:34 ` David Sterba [this message]
2021-01-28 10:51 ` Qu Wenruo
2021-02-01 14:50 ` David Sterba
2021-02-01 15:55 ` David Sterba
2021-02-02 9:21 ` [bug report] Unable to handle kernel paging request Anand Jain
2021-02-02 10:23 ` Qu Wenruo
2021-02-02 11:28 ` Anand Jain
2021-02-02 13:37 ` Anand Jain
2021-02-04 5:13 ` Qu Wenruo
2021-02-03 13:20 ` [PATCH v5 00/18] btrfs: add read-only support for subpage sector size David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128103452.GG1993@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).