From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8274EC43142 for ; Thu, 4 Mar 2021 00:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57C6364E56 for ; Thu, 4 Mar 2021 00:20:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1450345AbhCDATw (ORCPT ); Wed, 3 Mar 2021 19:19:52 -0500 Received: from mx2.suse.de ([195.135.220.15]:45612 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1447558AbhCCPEW (ORCPT ); Wed, 3 Mar 2021 10:04:22 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 23B42AD29; Wed, 3 Mar 2021 14:43:13 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 8BAB6DA82B; Wed, 3 Mar 2021 15:41:17 +0100 (CET) Date: Wed, 3 Mar 2021 15:41:17 +0100 From: David Sterba To: Josef Bacik Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] btrfs-progs: add a warning label for RAID5/6 Message-ID: <20210303144117.GK7604@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Josef Bacik , linux-btrfs@vger.kernel.org, kernel-team@fb.com References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On Tue, Aug 25, 2020 at 12:51:02PM -0400, Josef Bacik wrote: > We all know there's some dark and scary corners with RAID5/6, but users > may not know. Add a warning message in mkfs so anybody trying to use > this will know things can go very wrong. > > Signed-off-by: Josef Bacik > --- > mkfs/main.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mkfs/main.c b/mkfs/main.c > index 0a4de617..0db24ad4 100644 > --- a/mkfs/main.c > +++ b/mkfs/main.c > @@ -1183,6 +1183,8 @@ int BOX_MAIN(mkfs)(int argc, char **argv) > if ((data_profile | metadata_profile) & > (BTRFS_BLOCK_GROUP_RAID5 | BTRFS_BLOCK_GROUP_RAID6)) { > features |= BTRFS_FEATURE_INCOMPAT_RAID56; > + warning("RAID5/6 support is still experimental and has known " > + "issues, do not rely on this for data you care about.\n"); I've reworded the message, calling it experimental after so many years is a bit kappa. Also we'll need something in the docs for reference, I'll write something. > } > > if ((data_profile | metadata_profile) & > -- > 2.24.1