From: David Sterba <dsterba@suse.cz>
To: Zhen Lei <thunder.leizhen@huawei.com>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] btrfs: tests: remove unnecessary oom message
Date: Thu, 17 Jun 2021 22:35:18 +0200 [thread overview]
Message-ID: <20210617203518.GZ28158@twin.jikos.cz> (raw)
In-Reply-To: <20210617083053.1064-1-thunder.leizhen@huawei.com>
On Thu, Jun 17, 2021 at 04:30:53PM +0800, Zhen Lei wrote:
> Fixes scripts/checkpatch.pl warning:
> WARNING: Possible unnecessary 'out of memory' message
>
> Remove it can help us save a bit of memory.
Well, we have a few more messages in tests regarding failed memory
allocations. Though I've never seen one in practice, I think it's not
a big deal to have that one here as well. The failures in the testsuite
are intentionally verbose and saving a few bytes in optional development
feature hardly bothers anyone.
Where bytes can be saved are error messages for the same type of error,
that I've implemented in the past, see file fs/btrfs/tests/btrfs-tests.c
array test_error that maps enums to strings.
next prev parent reply other threads:[~2021-06-17 20:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 8:30 [PATCH 1/1] btrfs: tests: remove unnecessary oom message Zhen Lei
2021-06-17 20:35 ` David Sterba [this message]
2021-06-18 2:33 ` Leizhen (ThunderTown)
2021-06-18 5:58 ` Qu Wenruo
2021-06-18 6:05 ` Qu Wenruo
2021-06-23 20:41 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617203518.GZ28158@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).