From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH] fstests: btrfs/244: add test case to make sure kernel won't crash when deleting non-existing device
Date: Fri, 6 Aug 2021 18:46:47 +0800 [thread overview]
Message-ID: <20210806104647.312765-1-wqu@suse.com> (raw)
There is a kernel regression for btrfs, that when passing non-existing
devid to "btrfs device remove" command, kernel will crash due to NULL
pointer dereference.
The test case is for such regression, it will:
- Create and mount an empty single-device btrfs
- Try to remove devid 3, which doesn't exist for above fs
The fix is titled "btrfs: fix NULL pointer dereference when deleting
device by invalid id".
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
tests/btrfs/244 | 42 ++++++++++++++++++++++++++++++++++++++++++
tests/btrfs/244.out | 2 ++
2 files changed, 44 insertions(+)
create mode 100755 tests/btrfs/244
create mode 100644 tests/btrfs/244.out
diff --git a/tests/btrfs/244 b/tests/btrfs/244
new file mode 100755
index 00000000..56eb9e8c
--- /dev/null
+++ b/tests/btrfs/244
@@ -0,0 +1,42 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2021 SUSE Linux Products GmbH. All Rights Reserved.
+#
+# FS QA Test 244
+#
+# Make sure "btrfs device remove" won't crash when non-existing devid
+# is provided
+#
+. ./common/preamble
+_begin_fstest auto quick volume dangerous
+
+# Override the default cleanup function.
+# _cleanup()
+# {
+# cd /
+# rm -r -f $tmp.*
+# }
+
+# Import common functions.
+# . ./common/filter
+
+# real QA test starts here
+
+# Modify as appropriate.
+_supported_fs btrfs
+_require_scratch
+
+_scratch_mkfs >> $seqres.full 2>&1
+_scratch_mount
+
+# Above created fs only contains one device with devid 1, device remove 3
+# should just fail.
+# We don't care about the failure itself, but care whether this would cause
+# kernel crash.
+$BTRFS_UTIL_PROG device remove 3 $SCRATCH_MNT >> $seqres.full 2>&1
+
+echo "Silence is golden"
+
+# success, all done
+status=0
+exit
diff --git a/tests/btrfs/244.out b/tests/btrfs/244.out
new file mode 100644
index 00000000..440da1f2
--- /dev/null
+++ b/tests/btrfs/244.out
@@ -0,0 +1,2 @@
+QA output created by 244
+Silence is golden
--
2.31.1
next reply other threads:[~2021-08-06 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 10:46 Qu Wenruo [this message]
2021-08-06 11:13 ` [PATCH] fstests: btrfs/244: add test case to make sure kernel won't crash when deleting non-existing device Filipe Manana
2021-08-06 11:20 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806104647.312765-1-wqu@suse.com \
--to=wqu@suse.com \
--cc=fstests@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).